FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: add comments to pipeline implementation by ronag · Pull Request #32042 · nodejs/node · GitHub

/ node Public

stream: add comments to pipeline implementation - #32042

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:pipeline-comments
ConversationCommits (1)ChecksFiles changed
Closed

stream: add comments to pipeline implementation#32042
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:pipeline-comments

Conversation

ronag commented Mar 2, 2020

Copy link
Copy Markdown
Member

Fixes: #32039

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

ronag requested a review from mcollina March 2, 2020 11:46
ronag added the stream Issues and PRs related to the stream subsystem. label Mar 2, 2020
ronag force-pushed the pipeline-comments branch 2 times, most recently from d73d067 to 62aa7d4 Compare March 2, 2020 11:46
ronag force-pushed the pipeline-comments branch from 62aa7d4 to c374648 Compare March 2, 2020 11:47
mcollina approved these changes Mar 2, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 3, 2020

ronag commented Mar 7, 2020

Copy link
Copy Markdown
Member Author

Landed in 960be15

ronag closed this Mar 7, 2020
ronag added a commit that referenced this pull request Mar 7, 2020
stream: add comments to pipeline implementation
960be15 
Fixes: #32039

PR-URL: #32042
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
stream: add comments to pipeline implementation
2585b81 
Fixes: #32039

PR-URL: #32042
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 10, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid PassThrough to avoid buffering in pipeline

5 participants

Back | FazBrowse Home | New Git URL