FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

zlib: emits 'close' event after readble 'end' by tadjik1 · Pull Request #32050 · nodejs/node · GitHub

/ node Public

zlib: emits 'close' event after readble 'end' - #32050

Closed
tadjik1 wants to merge 1 commit into
nodejs:masterfrom
tadjik1:issue-32023-zlib-emits-close
ConversationCommits (1)ChecksFiles changed
Closed

zlib: emits 'close' event after readble 'end'#32050
tadjik1 wants to merge 1 commit into
nodejs:masterfrom
tadjik1:issue-32023-zlib-emits-close

Conversation

tadjik1 commented Mar 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey there,
as far as I understand this PR breaks behaviour when zlib streams emit close event in case of successful end.

Since emitting close is the part of Readable.destroy implementation - .destroy must be called on ZlibBase instance. In this case (case of successful finish) this.on('end') should be sufficient.

Fixes: #32023

\cc @addaleax

zlib: emits 'close' event after readble 'end'
7cc5dcb 
Call the close method after readable 'end' so that 'close' will be
emitted afterwards.

Fixes: nodejs#32023
nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Mar 2, 2020
addaleax approved these changes Mar 2, 2020
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29495/

tadjik1 commented Mar 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@addaleax thanks for such a quick response!
I have a question regarding failing CI: one test fails on MacOS Catalina test/sequential/test-timers-blocking-callback.js but it doesn't seem relevant to my changes, more like a flaky test.
Can we re-trigger this jenkins build to make sure that problem is somewhere in these changes?

addaleax commented Mar 2, 2020

Copy link
Copy Markdown
Member

Can we re-trigger this jenkins build to make sure that problem is somewhere in these changes?

Sure, done!

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29500/

aks- approved these changes Mar 3, 2020
View reviewed changes

aks- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

<3

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 9, 2020

addaleax commented Mar 11, 2020

Copy link
Copy Markdown
Member

Landed in 0c545f0

addaleax closed this Mar 11, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
zlib: emits 'close' event after readable 'end'
0c545f0 
Call the close method after readable 'end' so that 'close' will be
emitted afterwards.

Fixes: #32023

PR-URL: #32050
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
zlib: emits 'close' event after readable 'end'
f095e38 
Call the close method after readable 'end' so that 'close' will be
emitted afterwards.

Fixes: #32023

PR-URL: #32050
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins commented Mar 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This had landed on 13.x and was backed out as it seemed to break CI

might be best to land as a backport PR

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Mar 11, 2020
zlib: emits 'close' event after readable 'end'
74e2bbb 
Call the close method after readable 'end' so that 'close' will be
emitted afterwards.

Fixes: nodejs#32023

PR-URL: nodejs#32050
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Mar 11, 2020
Closed
ronag pushed a commit to nxtedition/node that referenced this pull request Mar 11, 2020
zlib: emits 'close' event after readable 'end'
1debf48 
Call the close method after readable 'end' so that 'close' will be
emitted afterwards.

Fixes: nodejs#32023

PR-URL: nodejs#32050
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Mar 19, 2020
Closed
4 tasks
BethGriggs mentioned this pull request Apr 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
+1 more reviewer
aks- aks- approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.on('close') for a readable stream stops working when going from node 12.14.0 to 12.16.1

8 participants

Back | FazBrowse Home | New Git URL