module: improve error for invalid package targets - #32052
Closed
MylesBorins wants to merge 9 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MylesBorins
force-pushed
the
better-errors
branch
from
057a205 to
0a23621
Compare
March 2, 2020 21:41
hybrist
reviewed
Mar 2, 2020
hybrist
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Woo! I think the error message doesn't match what we currently allow for exports values but overall looks good!
Sorry, something went wrong.
Comment thread
lib/internal/errors.js
Outdated
Comment thread
test/es-module/test-esm-exports.mjs
Outdated
Copy link
Copy Markdown
Member
|
LGTM pending jkrem's comment |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Good catch @jkrems PTAL |
Sorry, something went wrong.
GeoffreyBooth
approved these changes
Mar 3, 2020
guybedford
reviewed
Mar 3, 2020
guybedford
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for posting, this is huge for usability.
Would definitely be nice to see the tests covering the message if possible.
Sorry, something went wrong.
Comment thread
lib/internal/errors.js
Outdated
BridgeAR
approved these changes
Mar 9, 2020
3 tasks
For targets that are strings that do not start with `./` or `/` the error will now have additional information about what the programming error is. Closes: nodejs#32034
MylesBorins
force-pushed
the
better-errors
branch
from
d4c8b48 to
974e6c0
Compare
April 17, 2020 21:13
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/modules I've updated based on all feedback. Should work for both ESM + CJS and has a test that checks the error message. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ljharb
reviewed
Apr 17, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
lib/internal/errors.js
Outdated
Comment thread
lib/internal/errors.js
Outdated
Comment thread
lib/internal/errors.js
hybrist
approved these changes
Apr 17, 2020
guybedford
reviewed
Apr 17, 2020
Comment thread
lib/internal/errors.js
Outdated
guybedford
approved these changes
Apr 17, 2020
guybedford
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Amazing thanks for driving this one through.
Sorry, something went wrong.
guybedford
reviewed
Apr 17, 2020
Comment thread
lib/internal/errors.js
Outdated
Co-Authored-By: Guy Bedford <guybedford@gmail.com>
Co-Authored-By: Guy Bedford <guybedford@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
GeoffreyBooth
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Feel free to disregard if you disagree, I just feel like a semicolon here is better grammar than -.
Sorry, something went wrong.
Comment thread
lib/internal/errors.js
Outdated
Comment thread
lib/internal/errors.js
Outdated
Comment thread
lib/internal/errors.js
Outdated
Comment thread
lib/internal/errors.js
Outdated
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MylesBorins
added a commit
that referenced
this pull request
Apr 22, 2020
For targets that are strings that do not start with `./` or `/` the error will now have additional information about what the programming error is. Closes: #32034 PR-URL: #32052 Fixes: #32034 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Signed-off-by: Myles Borins <myles.borins@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
For targets that are strings that do not start with `./` or `/` the error will now have additional information about what the programming error is. Closes: #32034 PR-URL: #32052 Fixes: #32034 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Signed-off-by: Myles Borins <myles.borins@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
For targets that are strings that do not start with `./` or `/` the error will now have additional information about what the programming error is. Closes: #32034 PR-URL: #32052 Fixes: #32034 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Signed-off-by: Myles Borins <myles.borins@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
For targets that are strings that do not start with `./` or `/` the error will now have additional information about what the programming error is. Closes: #32034 PR-URL: #32052 Fixes: #32034 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Signed-off-by: Myles Borins <myles.borins@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
For targets that are strings that do not start with `./` or `/` the error will now have additional information about what the programming error is. Closes: #32034 PR-URL: #32052 Fixes: #32034 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Signed-off-by: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For targets that are strings that do not start with ./ or / the
error will now have additional information about what the programming
error is.
Closes: #32034
PTAL @nodejs/modules