doc: change worker.takeHeapSnapshot to getHeapSnapshot - #32061
Closed
Flarna wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
9 tasks
addaleax
approved these changes
Mar 3, 2020
cjihrig
approved these changes
Mar 3, 2020
codebytere
approved these changes
Mar 3, 2020
Copy link
Copy Markdown
Member
|
Nit: To maintain alphabetical order, the entry will need to be moved from its current location to above worker.postMessage(). |
Sorry, something went wrong.
mmarchini
approved these changes
Mar 3, 2020
Copy link
Copy Markdown
Member
Author
moved. |
Sorry, something went wrong.
jasnell
approved these changes
Mar 3, 2020
lpinca
approved these changes
Mar 3, 2020
Trott
approved these changes
Mar 3, 2020
Copy link
Copy Markdown
Member
|
Is it worth to mention that this API doesn't share an identical signature with v8.getHeapSnapshot? i.e. worker.{take,get}Snapshot returns a promise of stream, and v8.getHeapSnapshot returns a plain stream. |
Sorry, something went wrong.
BridgeAR
approved these changes
Mar 9, 2020
Adapt doc to match implementation which exports getHeapSnapshot().
Flarna
force-pushed
the
doc_worker_getheadsnapshot
branch
from
9a60ad5 to
4a9b8cc
Compare
March 10, 2020 07:53
Copy link
Copy Markdown
Member
Author
|
rebased, hopefully ASAN build is now green. |
Sorry, something went wrong.
mmarchini
pushed a commit
that referenced
this pull request
Mar 10, 2020
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: #32061 Refs: #31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 10, 2020
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: #32061 Refs: #31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: nodejs#32061 Refs: nodejs#31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: #32061 Refs: #31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt doc to match implementation which exports getHeapSnapshot().
Refs: #31569
Refs:
node/lib/internal/worker.js
Line 323 in 987a673
Checklist