FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update AUTHORS list by rvagg · Pull Request #3211 · nodejs/node · GitHub

/ node Public

doc: update AUTHORS list - #3211

Merged
rvagg merged 0 commit into
nodejs:masterfrom
rvagg:update-authors
Oct 7, 2015
ConversationCommits (0)ChecksFiles changed
Merged

doc: update AUTHORS list#3211
rvagg merged 0 commit into
nodejs:masterfrom
rvagg:update-authors

Conversation

rvagg commented Oct 6, 2015

Copy link
Copy Markdown
Member

Update AUTHORS list using tools/update-authors.sh, this is a big one!

  • @reggi: you are going in to the AUTHORS file as reggi <thomas@reggi.com> based on your git info, could we have a full name for you instead of the nickname or would you prefer the shortened version?
  • @charlierudolph you are going in to the AUTHORS file as charlierudolph <charles.rudolph@originate.com> based on your git info, could we have a full name for you instead of the nickname or would you prefer the shortened version? Charles Rudolph perhaps?
  • @johannhof you are going in to the AUTHORS file as `Johann <git@johann-hofmann.com

    ` based on your git info, could we have a full name for you instead or would you prefer the shortened version?

johannhof commented Oct 6, 2015

Copy link
Copy Markdown

I'd prefer my full name: Johann Hofmann 👍

mscdex added the doc Issues and PRs related to the documentations. label Oct 6, 2015

charlierudolph commented Oct 6, 2015

Copy link
Copy Markdown

Charles Rudolph please. Thanks!

reggi commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

@rvagg Thanks! Full name please: Thomas Reggi

rvagg commented Oct 7, 2015

Copy link
Copy Markdown
Member Author

thanks @johannhof, @charlierudolph & @reggi! updated

PTAL reviewers, need signoff on this.

evanlucas commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

LGTM

rvagg closed this Oct 7, 2015
rvagg added a commit to rvagg/io.js that referenced this pull request Oct 7, 2015
doc: update AUTHORS list
0116da1 
Update AUTHORS list using tools/update-authors.sh

PR-URL: nodejs#3211
Reviewed-By: Evan Lucas <evanlucas@me.com>
rvagg merged commit 0116da1 into nodejs:master Oct 7, 2015
jasnell mentioned this pull request Oct 8, 2015
Closed
29 tasks
rvagg added a commit that referenced this pull request Oct 8, 2015
doc: update AUTHORS list
365cf22 
Update AUTHORS list using tools/update-authors.sh

PR-URL: #3211
Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell mentioned this pull request Oct 8, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL