esm: remove unused parameter on module.instantiate by himself65 · Pull Request #32147 · nodejs/node · GitHub

related commit a6b030d, but this parameter do nothing at all.

Lines 302 to 323 in c49286b

    
           void ModuleWrap::Instantiate(const FunctionCallbackInfo<Value>& args) { 
        
             Environment* env = Environment::GetCurrent(args); 
        
             Isolate* isolate = args.GetIsolate(); 
        
             ModuleWrap* obj; 
        
             ASSIGN_OR_RETURN_UNWRAP(&obj, args.This()); 
        
             Local<Context> context = obj->context_.Get(isolate); 
        
             Local<Module> module = obj->module_.Get(isolate); 
        
             TryCatchScope try_catch(env); 
        
             USE(module->InstantiateModule(context, ResolveCallback)); 
        
             // clear resolve cache on instantiate 
        
             obj->resolve_cache_.clear(); 
        
             if (try_catch.HasCaught() && !try_catch.HasTerminated()) { 
        
               CHECK(!try_catch.Message().IsEmpty()); 
        
               CHECK(!try_catch.Exception().IsEmpty()); 
        
               AppendExceptionLine(env, try_catch.Exception(), try_catch.Message(), 
        
                                   ErrorHandlingMode::MODULE_ERROR); 
        
               try_catch.ReThrow(); 
        
               return; 
        
             } 
        
           }

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request/29659/
retry osx: https://ci.nodejs.org/job/node-test-commit-osx/32502/

Landed in 517b047

PR-URL: #32147 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: nodejs#32147 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: #32610 PR-URL: #32147 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

esm: remove unused parameter on module.instantiate

a2efbbd

nodejs-github-bot added the esm Issues and PRs related to the ECMAScript Modules implementation. label Mar 8, 2020

devsnek approved these changes Mar 8, 2020

View reviewed changes

cjihrig approved these changes Mar 8, 2020

View reviewed changes

addaleax approved these changes Mar 9, 2020

View reviewed changes

BridgeAR approved these changes Mar 9, 2020

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 9, 2020

addaleax closed this Mar 11, 2020

MylesBorins mentioned this pull request Mar 12, 2020

v13.11.0 proposal #32185

Merged

codebytere mentioned this pull request Apr 4, 2020

v12.16.2 proposal #32313

Merged

esm: remove unused parameter on module.instantiate by himself65 · Pull Request #32147 · nodejs/node · GitHub

Uh oh!

Uh oh!

esm: remove unused parameter on module.instantiate - #32147

esm: remove unused parameter on module.instantiate#32147
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200308

himself65 commented Mar 8, 2020

Uh oh!

nodejs-github-bot commented Mar 9, 2020 •
edited by MylesBorins
Loading

Uh oh!

Uh oh!

addaleax commented Mar 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	void ModuleWrap::Instantiate(const FunctionCallbackInfo<Value>& args) {
	Environment* env = Environment::GetCurrent(args);
	Isolate* isolate = args.GetIsolate();
	ModuleWrap* obj;
	ASSIGN_OR_RETURN_UNWRAP(&obj, args.This());
	Local<Context> context = obj->context_.Get(isolate);
	Local<Module> module = obj->module_.Get(isolate);
	TryCatchScope try_catch(env);
	USE(module->InstantiateModule(context, ResolveCallback));

	// clear resolve cache on instantiate
	obj->resolve_cache_.clear();

	if (try_catch.HasCaught() && !try_catch.HasTerminated()) {
	CHECK(!try_catch.Message().IsEmpty());
	CHECK(!try_catch.Exception().IsEmpty());
	AppendExceptionLine(env, try_catch.Exception(), try_catch.Message(),
	ErrorHandlingMode::MODULE_ERROR);
	try_catch.ReThrow();
	return;
	}
	}

esm: remove unused parameter on module.instantiate by himself65 · Pull Request #32147 · nodejs/node · GitHub

Uh oh!

Uh oh!

esm: remove unused parameter on module.instantiate - #32147

esm: remove unused parameter on module.instantiate#32147himself65 wants to merge 1 commit intonodejs:masternodejs/node:masterfrom himself65:20200308himself65/node:20200308Copy head branch name to clipboard

Conversation

himself65 commented Mar 8, 2020

Checklist

Uh oh!

nodejs-github-bot commented Mar 9, 2020 • edited by MylesBorins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented Mar 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

esm: remove unused parameter on module.instantiate#32147
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200308

nodejs-github-bot commented Mar 9, 2020 •
edited by MylesBorins
Loading