FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: move inactive collaborators to emeriti by Trott · Pull Request #32151 · nodejs/node · GitHub

/ node Public

meta: move inactive collaborators to emeriti - #32151

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:emeritus-mar-2020
Mar 12, 2020
ConversationCommits (1)ChecksFiles changed
Merged

meta: move inactive collaborators to emeriti#32151
Trott merged 1 commit into
nodejs:masterfrom
Trott:emeritus-mar-2020

Conversation

Trott commented Mar 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

@claudiorodriguez @iarna @italoacasas @MoonBall @rubys @seishun @trevnorris If any of you wish to remain collaborators for any reason whatsoever, just let me know in the next 72 hours and I'll remove you from this PR. (You don't even have to tell me what the reason is. Leave a comment here or send me an email.)

Thanks for all the great contributions and collaboration over the years!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 8, 2020
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 9, 2020

Trott commented Mar 10, 2020

Copy link
Copy Markdown
Member Author

@nodejs/tsc

mcollina approved these changes Mar 10, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

rubys commented Mar 10, 2020

Copy link
Copy Markdown
Member

I wish to remain a collaborator.

Trott removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 10, 2020
jasnell previously requested changes Mar 10, 2020
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Given @rubys' request to remain, just making the -1 explicit until the PR is updated to reflect that.

Trott force-pushed the emeritus-mar-2020 branch from 99f9096 to ed47c2c Compare March 11, 2020 02:20
Trott dismissed jasnell’s stale review March 11, 2020 02:21

Restored rubys

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 11, 2020

Trott commented Mar 11, 2020

Copy link
Copy Markdown
Member Author

@seishun sent me an email saying they want to remain a collaborator, so I'll update this....

Trott removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 11, 2020
Trott force-pushed the emeritus-mar-2020 branch from ed47c2c to 8924c91 Compare March 12, 2020 04:40

Trott commented Mar 12, 2020

Copy link
Copy Markdown
Member Author

Restored @seishun. This should be ready to land. One more approval or re-approval for good measure would be great.

Trott force-pushed the emeritus-mar-2020 branch from 8924c91 to a99778e Compare March 12, 2020 04:44
MylesBorins approved these changes Mar 12, 2020
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

so long and thanks for all the commits

meta: move inactive collaborators to emeriti
e6a55b4 
I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Trott force-pushed the emeritus-mar-2020 branch from a99778e to e6a55b4 Compare March 12, 2020 05:37
Trott merged commit e6a55b4 into nodejs:master Mar 12, 2020

Trott commented Mar 12, 2020

Copy link
Copy Markdown
Member Author

Landed in e6a55b4

Trott deleted the emeritus-mar-2020 branch March 12, 2020 05:38
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
meta: move inactive collaborators to emeriti
5b9ce00 
I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
meta: move inactive collaborators to emeriti
397cbca 
I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
meta: move inactive collaborators to emeriti
4d0be3d 
I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.

Some replied affirmatively and I have moved those people to emeritus.

Others replied indicating a desire to remain collaborators, and I left
them as collaborators.

The remaining folks are being moved to emeritus in this change.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: #32151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos mentioned this pull request Apr 22, 2020
Merged
iuliana-prodan mentioned this pull request Jul 15, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
tniessen tniessen approved these changes
trivikr trivikr approved these changes
+2 more reviewers
MylesBorins MylesBorins approved these changes
hiroppy hiroppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL