FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v13.x] fs: fix writeFile[Sync] for non-seekable files by mildsunrise · Pull Request #32172 · nodejs/node · GitHub

/ node Public

[v13.x] fs: fix writeFile[Sync] for non-seekable files - #32172

Closed
mildsunrise wants to merge 1 commit into
nodejs:v13.x-stagingfrom
mildsunrise:v13.x-writefile-non-seekable
Closed

[v13.x] fs: fix writeFile[Sync] for non-seekable files#32172
mildsunrise wants to merge 1 commit into
nodejs:v13.x-stagingfrom
mildsunrise:v13.x-writefile-non-seekable

Conversation

Copy link
Copy Markdown
Contributor

Backport of #32006

Completely disables the use of positioned writes at
writeFile and writeFileSync, which allows it to work
with non-seekable files.

Fixes: nodejs#31926

PR-URL: nodejs#32006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. v13.x labels Mar 10, 2020

Copy link
Copy Markdown
Collaborator

MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
Completely disables the use of positioned writes at
writeFile and writeFileSync, which allows it to work
with non-seekable files.

Fixes: #31926

Backport-PR-URL: #32172
PR-URL: #32006
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Copy link
Copy Markdown
Contributor

landed in 1c4f4cc

mildsunrise deleted the v13.x-writefile-non-seekable branch March 10, 2020 21:17
targos pushed a commit that referenced this pull request Apr 20, 2020
Completely disables the use of positioned writes at
writeFile and writeFileSync, which allows it to work
with non-seekable files.

Fixes: #31926

Backport-PR-URL: #32172
PR-URL: #32006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL