FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: avoid destroying http1 objects by ronag · Pull Request #32197 · nodejs/node · GitHub

/ node Public

stream: avoid destroying http1 objects - #32197

Closed
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:pipeline-fix-destroyer
ConversationCommits (3)ChecksFiles changed
Closed

stream: avoid destroying http1 objects#32197
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:pipeline-fix-destroyer

Conversation

ronag commented Mar 11, 2020

Copy link
Copy Markdown
Member

http1 objects are coupled with their corresponding
res/req and cannot be treated independently as
normal streams. Add a special exception for this
in the pipeline cleanup.

Fixes: #32184

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

ronag added the stream Issues and PRs related to the stream subsystem. label Mar 11, 2020
ronag requested a review from addaleax March 11, 2020 12:44

ronag commented Mar 11, 2020

Copy link
Copy Markdown
Member Author

I'm sorry about 8a2b62e causing these troubles. I've tried to resolve these follow up issues as quickly as possible.

ronag requested a review from mcollina March 11, 2020 12:45
ronag added the v13.x label Mar 11, 2020
addaleax removed the v13.x label Mar 11, 2020

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29726/

mcollina commented Mar 11, 2020

Copy link
Copy Markdown
Member

@ronag are we sure we should not revert all of those fixes instead and redo a PR with all of them?

mcollina approved these changes Mar 11, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ronag commented Mar 11, 2020

Copy link
Copy Markdown
Member Author

@ronag are we sure we should not revert all of those fixes instead and redo a PR with all of them?

I would prefer not. Seems more difficult than fixing it.

I see your point though. If you would prefer revert I would be ok with that.

mcollina commented Mar 11, 2020

Copy link
Copy Markdown
Member

Let's see if something else pop up.

ronag force-pushed the pipeline-fix-destroyer branch 2 times, most recently from 5aeab8d to abd091c Compare March 11, 2020 13:35

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29727/

ronag added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 11, 2020
BridgeAR reviewed Mar 11, 2020
View reviewed changes
Comment thread test/parallel/test-stream-pipeline.js Outdated
MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2020

MylesBorins commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

can we fast track this? I'd like to see it land in the upcoming 13.11.0 release

@ronag looks like this needs a rebase

ronag added 3 commits March 11, 2020 16:51
stream: avoid destroying http1 objects
70eabc1 
http1 objects are coupled with their corresponding
res/req and cannot be treated independently as
normal streams. Add a special exception for this
in the pipeline cleanup.

Fixes: nodejs#32184
fixup: don't depend on private properties
bed9a32
fixup: suggestions
1415464
ronag force-pushed the pipeline-fix-destroyer branch from d83675f to 1415464 Compare March 11, 2020 15:51

ronag commented Mar 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

rebased @MylesBorins

nodejs-github-bot commented Mar 11, 2020 •
edited by MylesBorins
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29733/
retry linter: https://ci.nodejs.org/job/node-test-linter/33328/

mcollina commented Mar 11, 2020

Copy link
Copy Markdown
Member

+1 to fast track

MylesBorins commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

@ronag FWIW this patch is not going to land cleanly on v13.x. You might want to get started on a backport now if you have time. very much trying to get this out in today's release.

ronag mentioned this pull request Mar 11, 2020
Closed
4 tasks

MylesBorins commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

landed in f8f2089

MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
stream: avoid destroying http1 objects
f8f2089 
http1 objects are coupled with their corresponding
res/req and cannot be treated independently as
normal streams. Add a special exception for this
in the pipeline cleanup.

Fixes: #32184

PR-URL: #32197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 12, 2020
stream: avoid destroying http1 objects
66fe2d9 
http1 objects are coupled with their corresponding
res/req and cannot be treated independently as
normal streams. Add a special exception for this
in the pipeline cleanup.

Fixes: #32184

Backport-PR-URL: #32212
PR-URL: #32197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins mentioned this pull request Mar 12, 2020
Merged
ronag mentioned this pull request Apr 20, 2020
Closed
4 tasks
mafintosh mentioned this pull request Apr 20, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR left review comments
mcollina mcollina approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: socket hang up when uploading and streaming with pipeline

7 participants

Back | FazBrowse Home | New Git URL