FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: avoid destroying writable source by ronag · Pull Request #32198 · nodejs/node · GitHub

/ node Public

stream: avoid destroying writable source - #32198

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-pipeline-destroy
ConversationCommits (1)ChecksFiles changed
Closed

stream: avoid destroying writable source#32198
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-pipeline-destroy

Conversation

ronag commented Mar 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.

Fixes: 4d93e10#commitcomment-37751035

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

ronag added the stream Issues and PRs related to the stream subsystem. label Mar 11, 2020
ronag requested a review from jasnell March 11, 2020 12:57
ronag referenced this pull request Mar 11, 2020
stream: don't destroy final readable stream in pipeline
4d93e10 
If the last stream in a pipeline is still usable/readable
don't destroy it to allow further composition.

Fixes: #32105

PR-URL: #32110
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29728/

MylesBorins commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

can we fast track this? I'd like to see it land in the upcoming 13.11.0 release

@ronag looks like this needs a rebase

MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2020
ronag force-pushed the stream-pipeline-destroy branch from 0506fd0 to 7b3eccc Compare March 11, 2020 15:54

ronag commented Mar 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

rebased @MylesBorins

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29738/

jasnell reviewed Mar 11, 2020
View reviewed changes
Comment thread test/parallel/test-stream-pipeline.js Outdated

jasnell Mar 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A test that has a Duplex piping back in to itself would be good also

ronag Mar 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suppose this is a nit? Since we might want to fast-track this would you mind if I do so in a follow up PR later?

ronag added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 11, 2020
ronag requested review from lpinca and mcollina March 11, 2020 16:53

MylesBorins commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

@ronag fwiw you can't approve fastrack on your own PR

ronag commented Mar 11, 2020

Copy link
Copy Markdown
Member Author

@ronag fwiw you can't approve fastrack on your own PR

Np, I was +1 the rebase part of your comment. I'll remove my +1.

jasnell commented Mar 11, 2020

Copy link
Copy Markdown
Member

+1 to fast tracking

mcollina approved these changes Mar 11, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm and +1 to fast track

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29753/

MylesBorins commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

@ronag FWIW this patch is not going to land cleanly on v13.x. You might want to get started on a backport now if you have time. very much trying to get this out in today's release.

ronag mentioned this pull request Mar 11, 2020
Closed
4 tasks
szmarczak mentioned this pull request Mar 11, 2020
Closed
2 tasks

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29761/

stream: avoid destroying writable source
5daaddb 
User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.

Fixes: nodejs@4d93e10#commitcomment-37751035

ronag commented Mar 11, 2020

Copy link
Copy Markdown
Member Author

Fixed conflicts

ronag force-pushed the stream-pipeline-destroy branch from 7b3eccc to 5daaddb Compare March 11, 2020 19:34

nodejs-github-bot commented Mar 11, 2020 •
edited by MylesBorins
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29762/
rerun arm https://ci.nodejs.org/job/node-test-commit-arm-fanned/13814/

nodejs-github-bot commented Mar 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29766/

MylesBorins pushed a commit that referenced this pull request Mar 12, 2020
stream: avoid destroying writable source
2bfb340 
User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.

PR-URL: #32198
Refs: 4d93e10#commitcomment-37751035
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MylesBorins commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

landed in 2bfb340

MylesBorins pushed a commit that referenced this pull request Mar 12, 2020
stream: avoid destroying writable source
fab8c83 
User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.

Backport-PR-URL: #32212
PR-URL: #32198
Refs: 4d93e10#commitcomment-37751035
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins mentioned this pull request Mar 12, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
lpinca Awaiting requested review from lpinca

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL