FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add Ruben to TSC by mhdawson · Pull Request #32213 · nodejs/node · GitHub

/ node Public

doc: add Ruben to TSC - #32213

Closed
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:addRuben2
Closed

doc: add Ruben to TSC#32213
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:addRuben2

Conversation

Copy link
Copy Markdown
Member

Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 11, 2020

Copy link
Copy Markdown
Member Author

@BridgeAR Welcome!

Copy link
Copy Markdown
Member Author

Fast Track ?

mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2020
mhdawson added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 11, 2020

Copy link
Copy Markdown
Member Author

Once CI is complete I think this can land based on the fast track process.

ChALkeR requested a review from BridgeAR March 11, 2020 22:28

Copy link
Copy Markdown
Member

Thanks, you all!

Comment thread README.md Outdated
Trott pushed a commit that referenced this pull request Mar 12, 2020
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Mar 12, 2020

Copy link
Copy Markdown
Member

Landed in e458747

Trott closed this Mar 12, 2020
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Mar 19, 2020
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
mhdawson deleted the addRuben2 branch September 14, 2020 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL