stream: don't emit 'finish' after 'error' - #32275
Closed
ronag wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ronag
force-pushed
the
stream-error-finish
branch
2 times, most recently
from
7999e19 to
96e82ca
Compare
March 14, 2020 23:59
ronag
force-pushed
the
stream-error-finish
branch
from
96e82ca to
48e7a2e
Compare
March 15, 2020 00:00
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Mar 15, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
reviewed
Mar 16, 2020
Comment thread
lib/_stream_writable.js
Outdated
jasnell
approved these changes
Mar 16, 2020
Co-Authored-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@ronag this doesn't land cleanly on v13.x, should it be backported? |
Sorry, something went wrong.
4 tasks
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 19, 2020
PR-URL: nodejs#32275 Refs: nodejs#28710 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: nodejs#32372
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An edge case could emit 'finish' after 'error'.
Refs: #28710
Checklist