FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: add --with-arm-fpu option by kapouer · Pull Request #3228 · nodejs/node · GitHub

/ node Public

build: add --with-arm-fpu option - #3228

Closed
kapouer wants to merge 2 commits into
nodejs:masterfrom
kapouer:patch-2
ConversationCommits (2)ChecksFiles changed
Closed

build: add --with-arm-fpu option#3228
kapouer wants to merge 2 commits into
nodejs:masterfrom
kapouer:patch-2

Conversation

kapouer commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

brendanashworth added build Issues and PRs related to build files or the CI. arm Issues and PRs related to the ARM architecture. labels Oct 7, 2015
mscdex reviewed Oct 7, 2015
View reviewed changes
Comment thread configure Outdated

mscdex Oct 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does it really make sense to make this explicit setting overridable by the configure script? It seems like if someone is passing the option explicitly, it should not be overridden. For example, what if an armv7 user would want to use vfp or vfpv2 instead of vfpv3 (e.g. for debugging or other reasons)?

kapouer commented Oct 7, 2015

Copy link
Copy Markdown
Contributor Author

I removed the default value of the option, set it inside the method which decides sane defaults,
but which honor the option in case it is set.

bnoordhuis reviewed Oct 7, 2015
View reviewed changes
Comment thread configure Outdated

bnoordhuis Oct 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

V8 also knows about vfpv3-d16. I don't know how common it is but might be nice to add.

bnoordhuis commented Oct 7, 2015

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/440/

bnoordhuis commented Oct 7, 2015

Copy link
Copy Markdown
Member

LGTM, I'll squash it when I land it. @mscdex LGTY?

mscdex commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

LGTM I guess the test-stringbytes-external failure on node-test-binary-arm is not related...

bnoordhuis pushed a commit that referenced this pull request Oct 7, 2015
build: add --with-arm-fpu option
17665af 
Fixes: #2942
PR-URL: #3228
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>

bnoordhuis commented Oct 7, 2015

Copy link
Copy Markdown
Member

Landed in 17665af, thanks.

@mscdex test-stringbytes-external is failure prone on underpowered machines, it allocates a lot of memory.

bnoordhuis closed this Oct 7, 2015
jasnell mentioned this pull request Oct 8, 2015
Closed
29 tasks
jasnell pushed a commit that referenced this pull request Oct 8, 2015
build: add --with-arm-fpu option
b3c5ad1 
Fixes: #2942
PR-URL: #3228
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
jasnell mentioned this pull request Oct 8, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL