FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: replace handle dereference with ContainerOf macro by HarshithaKP · Pull Request #32298 · nodejs/node · GitHub

/ node Public

src: replace handle dereference with ContainerOf macro - #32298

Closed
HarshithaKP wants to merge 2 commits into
nodejs:masterfrom
HarshithaKP:handle_dereference_process_wrap
ConversationCommits (2)ChecksFiles changed
Closed

src: replace handle dereference with ContainerOf macro#32298
HarshithaKP wants to merge 2 commits into
nodejs:masterfrom
HarshithaKP:handle_dereference_process_wrap

Conversation

HarshithaKP commented Mar 16, 2020

Copy link
Copy Markdown
Member

this was influenced by #32269

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. labels Mar 16, 2020
addaleax approved these changes Mar 16, 2020
View reviewed changes
Comment thread src/process_wrap.cc Outdated

nodejs-github-bot commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29864/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 29, 2020

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30198/

addaleax pushed a commit that referenced this pull request Mar 29, 2020
src: replace handle dereference with ContainerOf
768b0f5 
this was influenced by #32269

PR-URL: #32298
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax commented Mar 29, 2020

Copy link
Copy Markdown
Member

Landed in 768b0f5

addaleax closed this Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
src: replace handle dereference with ContainerOf
06bff18 
this was influenced by #32269

PR-URL: #32298
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
src: replace handle dereference with ContainerOf
4155358 
this was influenced by #32269

PR-URL: #32298
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Apr 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL