| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Test added in d1f2404 does not pass linting rule added in 3de353b. Fixed in this commit. `common` module required in all tests except those that intentionally leak variables. Fixes: nodejs#3229
Sorry, something went wrong.
|
/cc @indutny This minor change to your test look good to you? |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
@Trott I didn't see any errors when committing it. Are you sure that it is required for addons? |
Sorry, something went wrong.
|
@indutny Yes, I'm postive. $ git checkout d1f2404
Note: checking out 'd1f2404'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b new_branch_name
HEAD is now at d1f2404... buffer: FreeCallback should be tied to ArrayBuffer
$ make jslint
./node tools/eslint/bin/eslint.js src lib test tools/eslint-rules \
--rulesdir tools/eslint-rules --reset --quiet
test/addons/buffer-free-callback/test.js
1:0 error Mandatory module "common" must be loaded required-modules
✖ 1 problem (1 error, 0 warnings)
make: *** [jslint] Error 1
$
|
Sorry, something went wrong.
|
Ok, LGTM then. |
Sorry, something went wrong.
|
Shouldn't it go to other addons too? |
Sorry, something went wrong.
|
Yes, all the previously existing addon tests that didn't use common got it in c78091d which is the commit immediately prior to the linting rule. |
Sorry, something went wrong.
|
Because this change is so small and CI will fail until it lands, I'm going to go ahead and land it right away. |
Sorry, something went wrong.
Test added in d1f2404 does not pass linting rule added in 3de353b. Fixed in this commit. `common` module required in all tests except those that intentionally leak variables. PR-URL: #3230 Fixes: #3229 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Test added in d1f2404 does not pass linting rule added in 3de353b. Fixed in this commit. `common` module required in all tests except those that intentionally leak variables. PR-URL: #3230 Fixes: #3229 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
| Back | FazBrowse Home | New Git URL |
Test added in d1f2404 does not pass linting rule added in 3de353b.
Fixed in this commit. common module required in all tests except
those that intentionally leak variables.
Fixes: #3229