FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: update comment for SetImmediate() by addaleax · Pull Request #32300 · nodejs/node · GitHub

/ node Public

src: update comment for SetImmediate() - #32300

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:setimmediate-c++-comment
Closed

src: update comment for SetImmediate()#32300
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:setimmediate-c++-comment

Conversation

Copy link
Copy Markdown
Member

Refs: #31502 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 16, 2020
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 20, 2020

Copy link
Copy Markdown
Collaborator

jasnell pushed a commit that referenced this pull request Mar 21, 2020
Refs: #31502 (comment)

PR-URL: #32300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Mar 21, 2020

Copy link
Copy Markdown
Member

Landed in 064a670

jasnell closed this Mar 21, 2020
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
Refs: #31502 (comment)

PR-URL: #32300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 24, 2020
targos pushed a commit that referenced this pull request Apr 22, 2020
Refs: #31502 (comment)

PR-URL: #32300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL