src: clean up stream_base.h and stream-base-inl.h - #32307
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
force-pushed
the
cleanup-streambase
branch
from
0f6ef69 to
ac42fe6
Compare
March 16, 2020 21:15
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Mar 16, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
cleanup-streambase
branch
from
ff51b55 to
098cbcf
Compare
March 16, 2020 21:39
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nodejs/collaborators would be awesome to get another review on this one if possible. |
Sorry, something went wrong.
gengjiawen
reviewed
Mar 19, 2020
Comment thread
src/stream_wrap.cc
| using v8::Local; | ||
| using v8::MaybeLocal; | ||
| using v8::Object; | ||
| using v8::PropertyAttribute; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
addtional for quic?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
No, there's one use of PropertyAttribute elsewhere in the file. This was previously being inherited from the stream_base.h headers.
Sorry, something went wrong.
gengjiawen
approved these changes
Mar 19, 2020
gengjiawen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Mar 19, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32307 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 19, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32307 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32307 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream_base.h and stream_base-inl.h have always been a bit of a mess with regards to inlines, v8:: scopes, and more. This is the first step at a cleanup.
Checklist