FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add help repo link to CONTRIBUTING.md by dougshamoo · Pull Request #3233 · nodejs/node · GitHub

/ node Public

doc: add help repo link to CONTRIBUTING.md - #3233

Closed
dougshamoo wants to merge 3 commits into
nodejs:masterfrom
dougshamoo:contrib-add-help
ConversationCommits (3)ChecksFiles changed
Closed

doc: add help repo link to CONTRIBUTING.md#3233
dougshamoo wants to merge 3 commits into
nodejs:masterfrom
dougshamoo:contrib-add-help

Conversation

dougshamoo commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.

Fixes: #3185

doc: add help repo link to CONTRIBUTING.md
2f17226 
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.

Fixes: nodejs#3185
Trott reviewed Oct 7, 2015
View reviewed changes
Comment thread CONTRIBUTING.md Outdated

Trott Oct 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What do you think of something more like this: For general help using Node.js, please file an issue at... I think that may be easier to grok than issues related to using Node.js that are not issues with the Node.js software itself...

dougshamoo Oct 7, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think you're probably right. I may have tried to go a bit to dry and technical with it. Should I do a new commit?

Trott Oct 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, go ahead with a second commit on top of this one. (You or I or someone else can squash 'em all down into one commit later.)

Thanks for tackling this, by the way!

dougshamoo Oct 7, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Committed. Thanks for being awesome!

Trott added the doc Issues and PRs related to the documentations. label Oct 7, 2015
doc: add help repo link to CONTRIBUTING.md
3dca49f 
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.
Update Language.

Fixes: nodejs#3185
evanlucas reviewed Oct 7, 2015
View reviewed changes
Comment thread CONTRIBUTING.md Outdated

evanlucas Oct 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

perhaps use [Node.js help repository]?

Trott Oct 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agree with the nit. It's Node.js in documentation and other prose so we should use that here.

evanlucas commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

Other than that, LGTM

doc: add help repo link to CONTRIBUTING.md
fc1916f 
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.
Update Language.

Fixes: nodejs#3185

targos commented Oct 7, 2015

Copy link
Copy Markdown
Member

LGTM

1 similar comment

Trott commented Oct 8, 2015

Copy link
Copy Markdown
Member

LGTM

Trott pushed a commit that referenced this pull request Oct 8, 2015
doc: add help repo link to CONTRIBUTING.md
35cdded 
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.

PR-URL: #3233
Fixes: #3185
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Oct 8, 2015

Copy link
Copy Markdown
Member

Landed in 35cdded. Thanks for the contribution!

Trott closed this Oct 8, 2015
jasnell pushed a commit that referenced this pull request Oct 8, 2015
doc: add help repo link to CONTRIBUTING.md
d4fc6d9 
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.

PR-URL: #3233
Fixes: #3185
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell mentioned this pull request Oct 8, 2015
Closed

MylesBorins commented Nov 17, 2015

Copy link
Copy Markdown
Contributor

landed in v4.x-staging in d4fc6d9

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL