FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: mark classes while inspecting them by BridgeAR · Pull Request #32332 · nodejs/node · GitHub

/ node Public

util: mark classes while inspecting them - #32332

Closed
BridgeAR wants to merge 3 commits into
masterfrom
2020-03-17-highlight-classes-while-inspecting
ConversationCommits (3)ChecksFiles changed
Closed

util: mark classes while inspecting them#32332
BridgeAR wants to merge 3 commits into
masterfrom
2020-03-17-highlight-classes-while-inspecting

Conversation

BridgeAR commented Mar 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This outlines the basic class setup when inspecting a class.

The implementation is a bit tricky but it should cover all edge cases.

Fixes: #32270

Signed-off-by: Ruben Bridgewater ruben@bridgewater.de

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Mar 17, 2020
BridgeAR requested a review from addaleax March 17, 2020 21:38
mscdex reviewed Mar 17, 2020
View reviewed changes
Comment thread test/parallel/test-util-inspect.js Outdated
himself65 reviewed Mar 18, 2020
View reviewed changes
Comment thread test/parallel/test-util-inspect.js Outdated
BridgeAR force-pushed the 2020-03-17-highlight-classes-while-inspecting branch from 70f4a4e to 5fb30dc Compare March 18, 2020 22:31
devsnek previously requested changes Mar 18, 2020
View reviewed changes
Comment thread lib/internal/util/inspect.js Outdated
Ruben Bridgewater and others added 2 commits May 8, 2020 10:52
util: mark classes while inspecting them
3e7470e 
This outlines the basic class setup when inspecting a class.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
fixup: address comment
03007cb 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR force-pushed the 2020-03-17-highlight-classes-while-inspecting branch from 5fb30dc to 03007cb Compare May 8, 2020 15:14
fixup
ef81350 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

nodejs-github-bot commented May 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31294/

devsnek dismissed their stale review May 12, 2020 16:29

outdated

MEGAPUNSH approved these changes May 14, 2020
View reviewed changes

MEGAPUNSH left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

2020-03-17-highlight-classes-while-inspecting

BridgeAR commented May 17, 2020

Copy link
Copy Markdown
Member Author

@nodejs/util PTAL. This is open for quite a while by now.

addaleax approved these changes May 17, 2020
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 17, 2020

nodejs-github-bot commented May 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31366/

nodejs-github-bot commented May 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31369/

nodejs-github-bot commented May 18, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31375/

nodejs-github-bot commented May 18, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31396/

addaleax commented May 20, 2020

Copy link
Copy Markdown
Member

Landed in 3a51588

addaleax closed this May 20, 2020
addaleax pushed a commit that referenced this pull request May 20, 2020
util: mark classes while inspecting them
3a51588 
This outlines the basic class setup when inspecting a class.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #32332
Fixes: #32270
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax deleted the 2020-03-17-highlight-classes-while-inspecting branch May 20, 2020 10:32
codebytere pushed a commit that referenced this pull request Jun 18, 2020
util: mark classes while inspecting them
2380d90 
This outlines the basic class setup when inspecting a class.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #32332
Fixes: #32270
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 6, 2020
util: mark classes while inspecting them
e3533ab 
This outlines the basic class setup when inspecting a class.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #32332
Fixes: #32270
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere mentioned this pull request Jul 13, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

himself65 himself65 left review comments
addaleax addaleax approved these changes
+4 more reviewers
mscdex mscdex left review comments
devsnek devsnek left review comments
antsmartian antsmartian approved these changes
MEGAPUNSH MEGAPUNSH approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

minor request on logging classes

8 participants

Back | FazBrowse Home | New Git URL