build: add commit message linting to workflow - #32336
Conversation
Sorry, something went wrong.
|
FYI this will not work because it is using GITHUB_TOKEN and most all PRs we receive come from forks (GITHUB_TOKEN for PRs coming from forks are read-only, meaning they can't set labels, send comments, etc.). Edit: this is easy to test by the way, change the commit message to something not following our guidelines :) |
Sorry, something went wrong.
Run linting on the commit message of the first commit in a pull request as part of our GitHub actions CI workflow. If linting fails the pull request will be labelled as requiring a fix to the commit message. The check itself will always pass so as to not concern first time contributors. Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Yes, you're right. https://github.com/nodejs/node/pull/32336/checks?check_run_id=515383424#step:5:9 ℹ info label [ 'needs commit message fix' ]
✖ fatal HttpError: Resource not accessible by integration
at /node_modules/@octokit/request/lib/request.js:56:27
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async Object.doLabel [as label] (/entrypoint.js:61:5)
action failed
Pity. |
Sorry, something went wrong.
Run linting on the commit message of the first commit in a pull
request as part of our GitHub actions CI workflow. If linting fails
the pull request will be labelled as requiring a fix to the commit
message. The check itself will always pass so as to not concern
first time contributors.
This is a different approach to the commit message linting that
is currently run on Travis CI. The new label introduced by this
pull request (needs commit message fix) could also be added
manually for cases where the commit message needs updating
before landing for things not caught by core-validate-commit
(e.g. typos). We can also teach node-core-utils to check for the
label when landing pull requests (for those things not caught by
core-validate-commit).
Checklist