FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc,crypto: clarify oaepHash option's impact by panva · Pull Request #32340 · nodejs/node · GitHub

/ node Public

doc,crypto: clarify oaepHash option's impact - #32340

Closed
panva wants to merge 1 commit into
nodejs:masterfrom
panva:crypto-docs-update
Closed

doc,crypto: clarify oaepHash option's impact#32340
panva wants to merge 1 commit into
nodejs:masterfrom
panva:crypto-docs-update

Conversation

panva commented Mar 18, 2020

Copy link
Copy Markdown
Member

Introduced in #28335 this option also applies the hash function to MGF1, not just OAEP. This doc update makes that clear.

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Mar 18, 2020
panva force-pushed the crypto-docs-update branch from 2ddc5e5 to 88db298 Compare March 19, 2020 22:02
panva force-pushed the crypto-docs-update branch from 88db298 to d823572 Compare March 21, 2020 12:45

panva commented Mar 21, 2020

Copy link
Copy Markdown
Member Author

Can't do much about the failing CI, it seems to be just timeouts... over a doc update?

Copy link
Copy Markdown
Member

Restarted.

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 29, 2020

Copy link
Copy Markdown
Member

Landed in 154d4e5

addaleax closed this Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 29, 2020
PR-URL: #32340
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
PR-URL: #32340
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #32340
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
panva deleted the crypto-docs-update branch October 13, 2022 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL