FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: ICU 66.1 by srl295 · Pull Request #32348 · nodejs/node · GitHub

/ node Public

deps: ICU 66.1 - #32348

Closed
srl295 wants to merge 0 commit into
nodejs:masterfrom
srl295:icu-66.1
Closed

deps: ICU 66.1#32348
srl295 wants to merge 0 commit into
nodejs:masterfrom
srl295:icu-66.1

Conversation

srl295 commented Mar 18, 2020
edited
Loading

Copy link
Copy Markdown
Member

It's that time again…  Prior PR: #30232 for 65.2

By the way, this is a very small focussed release of ICU—just Unicode 13 and selected patches.

srl295 added i18n-api Issues and PRs related to the i18n implementation. dependencies Pull requests that update a dependency file. labels Mar 18, 2020
srl295 requested review from richardlau and ryzokuken March 18, 2020 19:50
srl295 self-assigned this Mar 18, 2020
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 18, 2020
srl295 marked this pull request as ready for review March 18, 2020 19:52

srl295 commented Mar 18, 2020

Copy link
Copy Markdown
Member Author

See also #32347 (not required to land this)

srl295 requested a review from devsnek March 18, 2020 20:21

ryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 18, 2020

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber stamp LGTM

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber stamp LGTM

Copy link
Copy Markdown
Collaborator

srl295 added a commit that referenced this pull request Mar 21, 2020
- ICU 66.1 http://site.icu-project.org/download/66
- Unicode 13
- CLDR 36.1
- Updated ./LICENSE

PR-URL: #32348
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
srl295 closed this Mar 21, 2020

srl295 commented Mar 21, 2020

Copy link
Copy Markdown
Member Author

Landed in 74e7e72

srl295 deleted the icu-66.1 branch March 21, 2020 00:30

srl295 commented Mar 21, 2020

Copy link
Copy Markdown
Member Author

fyi @nodejs/i18n @nodejs/i18n-api

MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
- ICU 66.1 http://site.icu-project.org/download/66
- Unicode 13
- CLDR 36.1
- Updated ./LICENSE

PR-URL: #32348
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Mar 24, 2020

targos commented Apr 22, 2020

Copy link
Copy Markdown
Member

Please open a backport PR for v12.x-staging

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL