test: improve test-cluster-net-listen-ipv6only-false - #32398
Merged
Trott merged 2 commits intoMar 28, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Mar 21, 2020
Comment thread
test/parallel/test-cluster-net-listen-ipv6only-false.js
Outdated
Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: nodejs#32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Use Promise.all() instead of countdown in test-cluster-net-listen-ipv6only-false. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: nodejs#32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
Use Promise.all() instead of countdown in test-cluster-net-listen-ipv6only-false. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Use Promise.all() instead of countdown in test-cluster-net-listen-ipv6only-false. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed this one in #32381. Use Array instead of Map, use Promise.all() instead of countdown.
Checklist