FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: delete CallbackInfo when cleared from cleanup hook by addaleax · Pull Request #32405 · nodejs/node · GitHub

/ node Public

src: delete CallbackInfo when cleared from cleanup hook - #32405

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:buffer-callback
ConversationCommits (1)ChecksFiles changed
Closed

src: delete CallbackInfo when cleared from cleanup hook#32405
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:buffer-callback

Conversation

addaleax commented Mar 21, 2020

Copy link
Copy Markdown
Member

Fixes: #32400

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Mar 21, 2020
addaleax mentioned this pull request Mar 21, 2020
Closed
mmarchini approved these changes Mar 21, 2020
View reviewed changes

mmarchini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Will run ASAN tests tomorrow to confirm, but I think it should fix it. Thank you!

addaleax commented Mar 21, 2020

Copy link
Copy Markdown
Member Author

@mmarchini Fwiw, I could reproduce the leak reported by ASAN with valgrind, and valgrind doesn’t report it anymore :)

addaleax mentioned this pull request Mar 21, 2020
Closed
3 tasks
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 21, 2020

nodejs-github-bot commented Mar 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29968/

mmarchini pushed a commit that referenced this pull request Mar 23, 2020
src: delete CallbackInfo when cleared from cleanup hook
678e1be 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

mmarchini commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

Landed in 678e1be

mmarchini closed this Mar 23, 2020
addaleax deleted the buffer-callback branch March 23, 2020 18:11
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
src: delete CallbackInfo when cleared from cleanup hook
bd998bc 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 24, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
src: delete CallbackInfo when cleared from cleanup hook
2fe351f 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
src: delete CallbackInfo when cleared from cleanup hook
7aa2ee2 
Fixes: #32400

PR-URL: #32405
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Apr 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
gengjiawen gengjiawen approved these changes
+2 more reviewers
targos targos approved these changes
mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possible undefined behavior on buffer's CallbackInfo

7 participants

Back | FazBrowse Home | New Git URL