lib: fix fs.read when passing null value - #32479
Closed
himself65 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
himself65
force-pushed
the
20200325-fs
branch
2 times, most recently
from
7ac2c95 to
976b3f2
Compare
March 25, 2020 08:45
4 tasks
addaleax
approved these changes
Mar 25, 2020
cjihrig
approved these changes
Mar 25, 2020
evanlucas
approved these changes
Mar 25, 2020
lholmquist
approved these changes
Mar 25, 2020
Copy link
Copy Markdown
Member
|
Does this need a test? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Better than nothing. I will. |
Sorry, something went wrong.
himself65
force-pushed
the
20200325-fs
branch
5 times, most recently
from
1e1f29a to
66c46bf
Compare
March 25, 2020 17:52
addaleax
approved these changes
Mar 29, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32479 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Copy link
Copy Markdown
Member
|
Landed in defbc2e and updated the commit message while landing |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32479 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#32479 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32479 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
This was referenced Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it shouldn't use the default value when user passing null on options
Checklist