Fix signature of _write() in a comment - #3248
Closed
fabiosantoscode wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM, do you mind changing the commit message to be prefixed with stream: ? (example: 50daee7) |
Sorry, something went wrong.
This comment was a bit misleading, since it was missing the `encoding` argument.
fabiosantoscode
force-pushed
the
feature/stream-comment
branch
from
acd90bf to
d7c6edb
Compare
October 8, 2015 07:25
Copy link
Copy Markdown
Contributor
Author
|
There it is @brendanashworth, force pushed. |
Sorry, something went wrong.
brendanashworth
pushed a commit
that referenced
this pull request
Oct 14, 2015
This comment was a bit misleading, since it was missing the `encoding` argument. PR-URL: #3248 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Copy link
Copy Markdown
Contributor
|
Thanks @fabiosantoscode, landed in 85b74de. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This should likely be in LTS /cc @jasnell |
Sorry, something went wrong.
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Oct 26, 2015
This comment was a bit misleading, since it was missing the `encoding` argument. PR-URL: nodejs#3248 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 26, 2015
This comment was a bit misleading, since it was missing the `encoding` argument. PR-URL: #3248 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 29, 2015
This comment was a bit misleading, since it was missing the `encoding` argument. PR-URL: #3248 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading up on the stream source code and tripped on this thing, decided to fix it.
<3