FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "test: mark empty udp tests flaky on OS X" by lpinca · Pull Request #32489 · nodejs/node · GitHub

/ node Public

Revert "test: mark empty udp tests flaky on OS X" - #32489

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:revert/24a4f767
Closed

Revert "test: mark empty udp tests flaky on OS X"#32489
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:revert/24a4f767

Conversation

lpinca commented Mar 25, 2020

Copy link
Copy Markdown
Member

This reverts commit 24a4f76.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 25, 2020

lpinca commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

The issue seems to be fixed in macOS 10.15.4

lpinca commented Mar 25, 2020
edited
Loading

Copy link
Copy Markdown
Member Author

@nodejs/platform-macos @AshCripps

lpinca requested a review from sam-github March 25, 2020 18:33

Copy link
Copy Markdown
Contributor

Are these the tests that just failed in https://ci.nodejs.org/job/node-test-commit-osx/32914/#showFailuresLink from the unrelated to UDP #32207 ?

If so, they are still flaky.

lpinca commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

Yes, what is the macOS version on jenkins?

lpinca commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

It seems to be 10.15.1, can it be updated to 10.15.4?

Copy link
Copy Markdown
Member

The macs should be able to be updated, might be a bit disruptive.

This PR should be held off until the machines are updated.

lpinca added the blocked PRs that are blocked by other issues or PRs. label Mar 25, 2020

lpinca commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

Added blocked label.

Copy link
Copy Markdown
Member

https://ci.nodejs.org/job/node-test-commit-osx-AshCripps/10/nodes=test-nearform-macos10.15-x64-1/ passed with 10.15.4 but test.sequential/test-timers-blocking-callback failed again.

Now working on the other two machines

Copy link
Copy Markdown
Member

@lpinca All 1015 macs currently in CI are now 10.15.4 feel free to remove the blocked label

Copy link
Copy Markdown
Member

Will also need to be reverted on 12.x I believe

lpinca removed the blocked PRs that are blocked by other issues or PRs. label Mar 26, 2020

lpinca commented Mar 26, 2020

Copy link
Copy Markdown
Member Author

Done, thank you.

richardlau commented Mar 27, 2020
edited
Loading

Copy link
Copy Markdown
Member

As of #32450 we're now testing on macOS with GitHub Actions and as far as I can tell the macOS runners are still macOS 10.15.3.

richardlau added the blocked PRs that are blocked by other issues or PRs. label Mar 27, 2020

lpinca commented Mar 28, 2020

Copy link
Copy Markdown
Member Author

@richardlau it looks like tests marked as flaky are run, see https://github.com/nodejs/node/pull/32534/checks?check_run_id=541357985 so we should either unblock this or set FLAKY_TESTS to skip.

lpinca commented Mar 28, 2020

Copy link
Copy Markdown
Member Author

Nvm it's already set to dontcare.

Copy link
Copy Markdown
Member

We’ll still need to keep the tests marked as FLAKY (e.g. this is blocked) for either FLAKY_TESTS skip or dontcare.

lpinca removed the blocked PRs that are blocked by other issues or PRs. label Apr 2, 2020

lpinca commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

Removed "blocked" again as macOS runners now use 10.15.4

Copy link
Copy Markdown
Collaborator

lpinca added a commit that referenced this pull request Apr 6, 2020
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

lpinca commented Apr 6, 2020

Copy link
Copy Markdown
Member Author

Landed in f675e3a.

lpinca closed this Apr 6, 2020
lpinca deleted the revert/24a4f767 branch April 6, 2020 16:30
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
richardlau pushed a commit that referenced this pull request Jul 1, 2020
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
richardlau mentioned this pull request Jul 2, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL