FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Clarify API Buffer.concat by Martii · Pull Request #3255 · nodejs/node · GitHub

/ node Public

doc: Clarify API Buffer.concat - #3255

Closed
Martii wants to merge 2 commits into
nodejs:masterfrom
Martii:Issue-3219docClarifyAPI_Buffer.concat
ConversationCommits (2)ChecksFiles changed
Closed

doc: Clarify API Buffer.concat#3255
Martii wants to merge 2 commits into
nodejs:masterfrom
Martii:Issue-3219docClarifyAPI_Buffer.concat

Conversation

Martii commented Oct 8, 2015

Copy link
Copy Markdown
  • Add a simple example for buffer.concat
  • Change grammar slightly.

Fixes: #3219

doc: Clarify API Buffer.concat
19c2bb7 
Add a simple example.
Change grammar slightly.

Closes #3219
mscdex added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Oct 8, 2015
ronkorving reviewed Oct 8, 2015
View reviewed changes
Comment thread doc/api/buffer.markdown Outdated

ronkorving Oct 8, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But it's not the length of the list, is it? It's the total byte size of all buffers combined if I'm not mistaken.

Martii Oct 8, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

perhaps "buffers in the list" would work better?

ronkorving Oct 8, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yes it would, thanks :)

Martii Oct 8, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No problem. Thank you.

doc: Clarify API Buffer.concat
70e7078 
Post fix for grammar

Applies to #3255 and #3219

jasnell commented Oct 14, 2015

Copy link
Copy Markdown
Member

LGTM

seishun commented Oct 15, 2015

Copy link
Copy Markdown
Contributor

I don't think an example is needed. TBH I think the current documentation is fine and the "in the list" part can be inferred.

jasnell commented Oct 21, 2015

Copy link
Copy Markdown
Member

@seishun ... more examples are almost never a bad thing to have in documentation.

trevnorris commented Oct 22, 2015

Copy link
Copy Markdown
Contributor

I'm cool w/ this. LGTM

jasnell pushed a commit that referenced this pull request Oct 22, 2015
doc: clarify API buffer.concat
e32aca6 
* Add a simple example for buffer.concat
* Change grammar slightly.

Fixes: #3219
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #3255

jasnell commented Oct 22, 2015

Copy link
Copy Markdown
Member

Landed in e32aca6. @Martii , I fixed up the commit log just a bit to match the common style.

jasnell closed this Oct 22, 2015

MylesBorins commented Oct 23, 2015

Copy link
Copy Markdown
Contributor

should this be in LTS

/cc @jasnell

jasnell commented Oct 23, 2015

Copy link
Copy Markdown
Member

@thealphanerd +1
On Oct 23, 2015 11:59 AM, "Myles Borins" notifications@github.com wrote:

should this be in LTS

/cc @jasnell https://github.com/jasnell

—
Reply to this email directly or view it on GitHub
#3255 (comment).

Martii commented Oct 23, 2015

Copy link
Copy Markdown
Author

@jasnell
Thanks... mirrored it to the original GH message minus the reviewers and pr number of course... wouldn't know those on a commit. Good for future reference.

jasnell pushed a commit that referenced this pull request Oct 26, 2015
doc: clarify API buffer.concat
4afcf57 
* Add a simple example for buffer.concat
* Change grammar slightly.

Fixes: #3219
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #3255

jasnell commented Oct 26, 2015

Copy link
Copy Markdown
Member

Landed in v4.x-staging in 4afcf57

rvagg pushed a commit that referenced this pull request Oct 26, 2015
doc: clarify API buffer.concat
cd245b1 
* Add a simple example for buffer.concat
* Change grammar slightly.

Fixes: #3219
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #3255
This was referenced Oct 27, 2015
Merged
Closed
jasnell pushed a commit that referenced this pull request Oct 29, 2015
doc: clarify API buffer.concat
e04cb1e 
* Add a simple example for buffer.concat
* Change grammar slightly.

Fixes: #3219
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #3255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL