src: multiple http2 refactorings - #32551
Closed
jasnell wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: James M Snell <jasnell@gmail.com>
Suppress compile warnings on Windows, rename class for consistent styling. Signed-off-by: James M Snell <jasnell@gmail.com>
* Simplify Http2Priority struct * BooleanValue => IsTrue/IsFalse Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
http2-refactorings
branch
from
3e118d6 to
9db4418
Compare
March 29, 2020 17:42
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Mar 29, 2020
Comment thread
src/node_http2.cc
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30180/ (:heavy_check_mark:) |
Sorry, something went wrong.
2 tasks
Trott
approved these changes
Mar 30, 2020
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Semi-rubber-stamp LGTM
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
Suppress compile warnings on Windows, rename class for consistent styling. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
* Simplify Http2Priority struct * BooleanValue => IsTrue/IsFalse Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Suppress compile warnings on Windows, rename class for consistent styling. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
* Simplify Http2Priority struct * BooleanValue => IsTrue/IsFalse Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Suppress compile warnings on Windows, rename class for consistent styling. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
* Simplify Http2Priority struct * BooleanValue => IsTrue/IsFalse Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32551 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist