test: test sys rather than common - #3256
Conversation
Sorry, something went wrong.
|
Since sys is just the same as util, can't we just make sure that all the tests in this file are done in the test-util* files and then just remove everything and do assert.strictEqual(require('sys'), require('util')) ? |
Sorry, something went wrong.
|
I'm with @targos on this. A lot of the tests are duplicated anyways |
Sorry, something went wrong.
|
OK, done, all sys tests moved to util and sys test replaced with a strictEqual() check that sys and util are the same thing. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/466/ Assuming CI is green, I'll land this in the next few hours unless someone objects. |
Sorry, something went wrong.
|
Well, that was embarrassing. Let's try this again. CI: https://ci.nodejs.org/job/node-test-pull-request/467/ |
Sorry, something went wrong.
|
@evanlucas Very minor change to correct a test I botched. Still LGTY? /cc @targos |
Sorry, something went wrong.
|
yep, LGTM |
Sorry, something went wrong.
test-sys.js tests common.inspect() (which is test-specific code) and not sys (which, although deprecated, should still be tested). This commit moves the tests to the not-deprecated util and adds a test to check that deprecated sys and util are the same. PR-URL: #3256 Reviewed-By: Evan Lucas <evanlucas@me.com>
test-sys.js tests common.inspect() (which is test-specific code) and not sys (which, although deprecated, should still be tested). This commit moves the tests to the not-deprecated util and adds a test to check that deprecated sys and util are the same. PR-URL: #3256 Reviewed-By: Evan Lucas <evanlucas@me.com>
test-sys.js seems to test common.inspect() (which is test-specific code) and not sys (which, although deprecated, should still be tested).
This seems like it was introduced in 9fd5e3c which is a pretty big commit with lots of probable find/replace.
This commit changes it to test sys which is what the file name implies it should be doing.