FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: Use constant kWriteFileMaxChunkSize by rickyes · Pull Request #32640 · nodejs/node · GitHub

/ node Public

fs: Use constant kWriteFileMaxChunkSize - #32640

Closed
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:refactor-fs-read-write-chunksize
ConversationCommits (1)ChecksFiles changed
Closed

fs: Use constant kWriteFileMaxChunkSize#32640
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:refactor-fs-read-write-chunksize

Conversation

rickyes commented Apr 3, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Apr 3, 2020

nodejs-github-bot commented Apr 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30439/

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30522/

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30529/

rickyes commented Apr 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

looks like the CI error has nothing to do with PR. What can I do to allow landing ? @puzpuzpuz

puzpuzpuz commented Apr 20, 2020

Copy link
Copy Markdown
Member

looks like the CI error has nothing to do with PR. What can I do to allow landing ? @puzpuzpuz

Let me start CI build for this one. Once we get a green build, this PR can be landed.

nodejs-github-bot commented Apr 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30864/

rickyes commented Apr 20, 2020

Copy link
Copy Markdown
Contributor Author

looks like the CI error has nothing to do with PR. What can I do to allow landing ? @puzpuzpuz

Let me start CI build for this one. Once we get a green build, this PR can be landed.

OK, It looks like get a green build.

puzpuzpuz commented Apr 20, 2020

Copy link
Copy Markdown
Member

OK, It looks like get a green build.

Thanks for the heads-up (and for the contribution). Going to land this one now.

puzpuzpuz pushed a commit that referenced this pull request Apr 20, 2020
fs: extract kWriteFileMaxChunkSize constant
33a5cd5 
PR-URL: #32640
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

puzpuzpuz commented Apr 20, 2020

Copy link
Copy Markdown
Member

Landed in 33a5cd5

puzpuzpuz closed this Apr 20, 2020
rickyes deleted the refactor-fs-read-write-chunksize branch April 20, 2020 17:17
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
fs: extract kWriteFileMaxChunkSize constant
baa8231 
PR-URL: #32640
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
fs: extract kWriteFileMaxChunkSize constant
04b1f63 
PR-URL: #32640
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR mentioned this pull request Apr 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
awibox awibox approved these changes
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL