FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: refactored scheduling policy assignment by yashLadha · Pull Request #32663 · nodejs/node · GitHub

/ node Public

lib: refactored scheduling policy assignment - #32663

Closed
yashLadha wants to merge 1 commit into
nodejs:masterfrom
yashLadha:chore/destructure_scheduling_policy
ConversationCommits (1)ChecksFiles changed
Closed

lib: refactored scheduling policy assignment#32663
yashLadha wants to merge 1 commit into
nodejs:masterfrom
yashLadha:chore/destructure_scheduling_policy

Conversation

yashLadha commented Apr 5, 2020

Copy link
Copy Markdown
Contributor

In previous implementation it was clubbed into declaration of scheduling
policies and fetching the schedulingPolicy. Now they are separate
variables, so that in future if one want to add new scheduling policy.
It is much simpler and not obsfucated.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label Apr 5, 2020
rickyes reviewed Apr 5, 2020
View reviewed changes
Comment thread lib/internal/cluster/master.js Outdated

rickyes Apr 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lint-js rule check error is triggered :)

yashLadha Apr 5, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, my bad. Done 👍

yashLadha force-pushed the chore/destructure_scheduling_policy branch from c93cf14 to 2579e7f Compare April 5, 2020 08:49

Trott commented Apr 13, 2020

Copy link
Copy Markdown
Member

@nodejs/cluster

bnoordhuis commented Apr 13, 2020

Copy link
Copy Markdown
Member

I'm really rather lukewarm when it comes to changes like this one. I might be biased because I wrote the current code but the new code is arguably less readable than the code it replaces.

yashLadha commented Apr 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@bnoordhuis is it specific to destructuring or the naming. Just wanted to know the cause 😄

bnoordhuis commented Apr 13, 2020

Copy link
Copy Markdown
Member

The destructuring. It's not that it's incredibly complex or difficult to follow, just harder to parse than the current code (IMO.)

yashLadha commented Apr 13, 2020

Copy link
Copy Markdown
Contributor Author

@bnoordhuis what should be the correct approach then according to you, because previously we are pulling the scheduling policy straight out from the hash which is not implying anything in general. 🤔

bnoordhuis commented Apr 13, 2020

Copy link
Copy Markdown
Member

Well, if you want to make an improvement, how about this?

let schedulingPolicy = process.env.NODE_CLUSTER_SCHED_POLICY;
if (schedulingPolicy === 'rr')
  schedulingPolicy = SCHED_RR;
else if (schedulingPolicy === 'none')
  schedulingPolicy = SCHED_NONE;
else if (process.platform === 'win32')
  // Round-robin doesn't perform well on Windows due to the way IOCP is wired up.
  schedulingPolicy = SCHED_NONE;
else
  schedulingPolicy = SCHED_RR;

That at least protects schedulingPolicy from jokers setting NODE_CLUSTER_SCHED_POLICY to __proto__ , constructor, etc.

It's a marginal improvement but marginal improvements are improvements too. :-)

yashLadha force-pushed the chore/destructure_scheduling_policy branch from 2579e7f to bc2ba78 Compare April 13, 2020 14:00
lib: refactored scheduling policy assignment
4985a2e 
In previous implementation it was clubbed into declaration of scheduling
policies and fetching the schedulingPolicy. Now they are separate
variables, so that in future if one want to add new scheduling policy.
It is much simpler and not obsfucated.
yashLadha force-pushed the chore/destructure_scheduling_policy branch from bc2ba78 to 4985a2e Compare April 13, 2020 14:25
mcollina approved these changes May 4, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 7, 2020

nodejs-github-bot commented May 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31217/

addaleax pushed a commit that referenced this pull request May 9, 2020
lib: refactored scheduling policy assignment
023bcde 
In previous implementation it was clubbed into declaration of scheduling
policies and fetching the schedulingPolicy. Now they are separate
variables, so that in future if one want to add new scheduling policy.
It is much simpler and not obsfucated.

PR-URL: #32663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

addaleax commented May 9, 2020

Copy link
Copy Markdown
Member

Landed in 023bcde

addaleax closed this May 9, 2020
codebytere pushed a commit that referenced this pull request May 11, 2020
lib: refactored scheduling policy assignment
94d0a08 
In previous implementation it was clubbed into declaration of scheduling
policies and fetching the schedulingPolicy. Now they are separate
variables, so that in future if one want to add new scheduling policy.
It is much simpler and not obsfucated.

PR-URL: #32663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
lib: refactored scheduling policy assignment
6881410 
In previous implementation it was clubbed into declaration of scheduling
policies and fetching the schedulingPolicy. Now they are separate
variables, so that in future if one want to add new scheduling policy.
It is much simpler and not obsfucated.

PR-URL: #32663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
codebytere mentioned this pull request Jun 9, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
bnoordhuis bnoordhuis approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
rickyes rickyes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. cluster Issues and PRs related to the cluster subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL