src: initialize inspector before RunBootstrapping() - #32672
Closed
addaleax wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Apr 5, 2020
devsnek
reviewed
Apr 5, 2020
Comment thread
src/inspector_io.cc
Outdated
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: nodejs#32648 Refs: nodejs#30467 (comment)
addaleax
force-pushed
the
inspector-init-createenvironment
branch
from
0979bd5 to
4ce0133
Compare
April 5, 2020 21:30
devsnek
reviewed
Apr 5, 2020
Comment thread
src/node.h
devsnek
approved these changes
Apr 5, 2020
Copy link
Copy Markdown
Member
Author
|
@devsnek Sorry, had to make a few changes to get tests to pass (some of which were rather obvious in hindsight) … could you take another look? |
Sorry, something went wrong.
devsnek
approved these changes
Apr 6, 2020
eugeneo
approved these changes
Apr 6, 2020
joyeecheung
approved these changes
Apr 6, 2020
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. I am still skeptical about whether it's necessary to burden users with maintaining InspectorParentHandle across threads through the Environment API, but it is what it is
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30502/ (:heavy_check_mark:) |
Sorry, something went wrong.
devnexen
approved these changes
Apr 6, 2020
jasnell
approved these changes
Apr 7, 2020
addaleax
added a commit
that referenced
this pull request
Apr 7, 2020
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: #32648 Refs: #30467 (comment) PR-URL: #32672 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: #32648 Refs: #30467 (comment) PR-URL: #32672 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
It looks like this PR is making cctest crash when coverage is enabled (see #32912). |
Sorry, something went wrong.
4 tasks
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Sep 23, 2020
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: nodejs#32648 Refs: nodejs#30467 (comment) PR-URL: nodejs#32672 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 23, 2020
This is necessary for `--inspect-brk-node` to work, and for the inspector to be aware of scripts created before bootstrapping. Fixes: #32648 Refs: #30467 (comment) Backport-PR-URL: #35241 PR-URL: #32672 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 20, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 8, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 9, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for --inspect-brk-node to work, and for the
inspector to be aware of scripts created before bootstrapping.
Fixes: #32648
Refs: #30467 (comment)
Checklist