doc: document buffer.from returns internal pool buffer - #32703
Closed
HarshithaKP wants to merge 3 commits into
Closed
doc: document buffer.from returns internal pool buffer#32703HarshithaKP wants to merge 3 commits into
HarshithaKP wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixes: nodejs#22139 Co-authored-by: Mritunjay Goutam <mritunjaygoutam2204@gmail.com>
Copy link
Copy Markdown
Member
Author
|
This is a re-work of stalled PR #24312. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Buffer.from(string) also does this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
@addaleax, PTAL. |
Sorry, something went wrong.
addaleax
approved these changes
Apr 7, 2020
Trott
reviewed
Apr 7, 2020
Comment thread
doc/api/buffer.md
Outdated
Trott
approved these changes
Apr 7, 2020
lpinca
approved these changes
Apr 7, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Apr 10, 2020
2 tasks
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Fixes: nodejs#22139 Co-authored-by: Mritunjay Goutam <mritunjaygoutam2204@gmail.com> PR-URL: nodejs#32703 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
3 tasks
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35541 Refs: nodejs#32703 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #22139
Co-authored-by: Mritunjay Goutam mritunjaygoutam2204@gmail.com
Checklist