FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: log detected compilers in --verbose mode by richardlau · Pull Request #32715 · nodejs/node · GitHub

/ node Public

build: log detected compilers in --verbose mode - #32715

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:configure-whatcomp
ConversationCommits (1)ChecksFiles changed
Closed

build: log detected compilers in --verbose mode#32715
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:configure-whatcomp

Conversation

richardlau commented Apr 8, 2020

Copy link
Copy Markdown
Member

Log the versions of the detected compilers when the configure script
is run with --verbose to help verify which compiler is being used if
multiple toolchains are installed on the system.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

build: log detected compilers in --verbose mode
65e3ef7 
Log the versions of the detected compilers when the configure script
is run with `--verbose` to help verify which compiler is being used if
multiple toolchains are installed on the system.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>
nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 8, 2020
richardlau mentioned this pull request Apr 8, 2020
Closed
38 tasks

This comment has been minimized.

Sign in to view
richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 8, 2020
rvagg approved these changes Apr 8, 2020
View reviewed changes

rvagg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice, I thought we had this printing out by default long ago, maybe prior to prittification

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Apr 8, 2020 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30565/ (✅)

sam-github commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

I request this be fast-tracked, its low impact, and will really help in compiler level audit for 14.x I think if @riclau and one other person thumbs this comment up, I can land it.

sam-github mentioned this pull request Apr 9, 2020
Merged

richardlau commented Apr 9, 2020

Copy link
Copy Markdown
Member Author

I request this be fast-tracked, its low impact, and will really help in compiler level audit for 14.x I think if @riclau and one other person thumbs this comment up, I can land it.

If you meant me I don't think I'd count towards fast tracking as the PR author, but you do and any other collaborator thumbing up your comment would count.

addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 9, 2020

sam-github commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

Actually, you do count! And even better, as the author, you are implicitly assumed to agree to fast-tracking :-)

Collaborators may request fast-tracking of pull requests they did not author.
In that case only, the request itself is also one fast-track approval. Upvote
the comment anyway to avoid any doubt.

So, you could thumbsup, but you don't have to, mine is enough.

I'm landing this.

sam-github commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

Landed in 7251e8c

sam-github closed this Apr 9, 2020
sam-github pushed a commit that referenced this pull request Apr 9, 2020
build: log detected compilers in --verbose mode
7251e8c 
Log the versions of the detected compilers when the configure script
is run with `--verbose` to help verify which compiler is being used if
multiple toolchains are installed on the system.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32715
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau deleted the configure-whatcomp branch April 9, 2020 16:05
mhdawson reviewed Apr 9, 2020
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

sam-github mentioned this pull request Apr 9, 2020
Closed
targos pushed a commit that referenced this pull request Apr 12, 2020
build: log detected compilers in --verbose mode
a11e3ef 
Log the versions of the detected compilers when the configure script
is run with `--verbose` to help verify which compiler is being used if
multiple toolchains are installed on the system.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32715
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Apr 13, 2020
Merged
sam-github pushed a commit to sam-github/node that referenced this pull request Apr 13, 2020
build: log detected compilers in --verbose mode
19740b9 
Log the versions of the detected compilers when the configure script
is run with `--verbose` to help verify which compiler is being used if
multiple toolchains are installed on the system.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: nodejs#32715
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
sam-github mentioned this pull request Apr 13, 2020
Closed
4 tasks

sam-github commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

backport to v10.x: #32820

12.x picks clean

It would be useful to have this in LTS for ease of verifying compiler levels.

BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
build: log detected compilers in --verbose mode
d2c0800 
Log the versions of the detected compilers when the configure script
is run with `--verbose` to help verify which compiler is being used if
multiple toolchains are installed on the system.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32715
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 22, 2020
build: log detected compilers in --verbose mode
ae772b7 
Log the versions of the detected compilers when the configure script
is run with `--verbose` to help verify which compiler is being used if
multiple toolchains are installed on the system.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32715
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Apr 22, 2020
Merged
richardlau added a commit that referenced this pull request Jul 1, 2020
build: log detected compilers in --verbose mode
9915774 
Log the versions of the detected compilers when the configure script
is run with `--verbose` to help verify which compiler is being used if
multiple toolchains are installed on the system.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32715
Backport-PR-URL: #32820
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau mentioned this pull request Jul 2, 2020
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
gireeshpunathil gireeshpunathil approved these changes
+3 more reviewers
mhdawson mhdawson left review comments
sam-github sam-github approved these changes
rvagg rvagg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL