doc: elevate diagnostic report to tier1 - #32732
Conversation
Sorry, something went wrong.
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such.
|
|
||
| | Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier | | ||
| |-----------|---------------------------|-------------------------------|-------------------------|-------------| | ||
| | FFDC | node-report | No | No | 1 | |
There was a problem hiding this comment.
I would rather either keep the npm node-report module as unclassified or moved to tier 4.
Sorry, something went wrong.
There was a problem hiding this comment.
I would move it to tier unclassified.
Sorry, something went wrong.
There was a problem hiding this comment.
@richardlau @mhdawson - reverted the case of node-report, PTAL!
Sorry, something went wrong.
For diagnostics report, since it's in core the tests for it are part of the regular test CI so no concerns there. I'm not sure the Release WG has been consulted on the broader Tier requirements. The only mechanism we have of running tests for releases is either (a) tests that exist in core and are therefore run as part of regular/nightly CI, or (b) CITGM (which can only test npms). I'm hesitant to place more requirements in the future on @nodejs/releasers. |
Sorry, something went wrong.
mhdawson
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
@richardlau agreed, for those tools to be tier 1 they need to be tested either on Node.js core or as part of CITGM. We should add this as a pre-requirement for Tier 1. |
Sorry, something went wrong.
mcollina
left a comment
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diagnostic WG recommends that: diagnostic report qualifies for all the criteria for being in tier1. Classify it as such.
checklist:
this is the first time a tool is potentially entering the tier1 status. As per the documented process, the most notable one is: A release will not be shipped if the test suite for the tool/API is not green. (this page, second para). So alerting the release team for their awareness and / or review.
@richardlau raised a point about retaining node-report in the unclassified list. While diagnostic report is replacement of node-report in principle, in reality both need to co-exist until v10.x goes out of support (04/21). I am fine in either way, but my opinion is to replace node-report in the list - node-report is an npm module, so its support tier status listing in core as unclassified or absence of it may not be too critical to the ecosystem.
Refs: nodejs/diagnostics#369
/cc @nodejs/releasers
/cc @nodejs/diagnostics
/cc @nodejs/tooling
Checklist