FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add himself65 to collaborators by himself65 · Pull Request #32734 · nodejs/node · GitHub

/ node Public

doc: add himself65 to collaborators - #32734

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:name
ConversationCommits (1)ChecksFiles changed
Closed

doc: add himself65 to collaborators#32734
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:name

Conversation

himself65 commented Apr 9, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 9, 2020

gabrielschulhof commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

May we please fast-track?

himself65 added fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs. labels Apr 9, 2020

Trott commented Apr 9, 2020

Copy link
Copy Markdown
Member

Yes, +1 to fast-tracking.

himself65 commented Apr 9, 2020

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4160/

gabrielschulhof commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

@Trott the CI is broken 😕 I think we should be OK landing this, right?

Trott commented Apr 9, 2020

Copy link
Copy Markdown
Member

Wrong CI. Don't use pipeline CI. Do not land yet.

gabrielschulhof commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

@Trott roger. What CI shall we use?

gabrielschulhof commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

@Trott wanna join our onboarding hangout? https://hangouts.google.com/u/0/call/a4zPSzgYJ7nDyG8CSe15AEEE

Trott commented Apr 9, 2020

Copy link
Copy Markdown
Member

Kick off https://ci.nodejs.org/job/node-test-pull-request, not the pipeline-lite job. That one is obsolete. For docs-only changes, we use GitHub action results instead of Jenkins. Otherwise, full Jenkins CI.

In this case, have the Collaborator kick off the regular CI job just to make sure it works for them. Once the bot posts the link here, you can cancel the job (which lets them know how to do that, in case they aren't familiar with Jenkins), and land.

gabrielschulhof commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

@Trott thanks!

nodejs-github-bot commented Apr 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30573/

juanarbol mentioned this pull request Apr 9, 2020
Closed
4 tasks
himself65 added a commit that referenced this pull request Apr 9, 2020
doc: add himself65 to collaborators
934ef43 
PR-URL: #32734
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

himself65 commented Apr 9, 2020

Copy link
Copy Markdown
Member Author

Landed in 934ef43

himself65 closed this Apr 9, 2020
himself65 deleted the name branch April 9, 2020 04:20

richardlau commented Apr 9, 2020

Copy link
Copy Markdown
Member

Kick off https://ci.nodejs.org/job/node-test-pull-request, not the pipeline-lite job. That one is obsolete. For docs-only changes, we use GitHub action results instead of Jenkins. Otherwise, full Jenkins CI.

In this case, have the Collaborator kick off the regular CI job just to make sure it works for them. Once the bot posts the link here, you can cancel the job (which lets them know how to do that, in case they aren't familiar with Jenkins), and land.

I strongly discourage cancelling jobs where possible as it can leave git workspaces in bad states.

targos pushed a commit that referenced this pull request Apr 12, 2020
doc: add himself65 to collaborators
9788b84 
PR-URL: #32734
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
doc: add himself65 to collaborators
73bc7bd 
PR-URL: #32734
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Apr 14, 2020
2020-04-14, Version 13.13.0 (Current)
4ca9571 
Notable changes:

New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
  This function takes an array of `ArrayBufferView` elements and will
  write the data it reads sequentially to the buffers
  (Sk Sajidul Kadir). #32356
* A new overload is available for `fs.readSync`, which allows to
  optionally pass any of the `offset`, `length` and `position`
  parameters. #32460

Other changes:
* dns:
  * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
    `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
    mapped IPv6 addresses (murgatroid99).
    #32183
* http:
  * The default maximum HTTP header size was changed from 8KB to 16KB
    (rosaxny). #32520
* n-api:
  * Calls to `napi_call_threadsafe_function` from the main thread can
    now return the `napi_would_deadlock` status in certain
    circumstances (Gabriel Schulhof).
    #32689
* util:
  * Added a new `maxStrLength` option to `util.inspect`, to control the
    maximum length of printed strings. Its default value is `Infinity`
    (rosaxny). #32392
* worker:
  * Added support for passing a `transferList` along with `workerData`
    to the `Worker` constructor (Juan José Arboleda).
    #32278

New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. #32734
* flarna (Gerhard Stoebich). #32620
* mildsunrise (Alba Mendez). #32525

PR-URL: #32813
targos added a commit that referenced this pull request Apr 14, 2020
2020-04-14, Version 13.13.0 (Current)
8130521 
Notable changes:

New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
  This function takes an array of `ArrayBufferView` elements and will
  write the data it reads sequentially to the buffers
  (Sk Sajidul Kadir). #32356
* A new overload is available for `fs.readSync`, which allows to
  optionally pass any of the `offset`, `length` and `position`
  parameters. #32460

Other changes:
* dns:
  * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
    `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
    mapped IPv6 addresses (murgatroid99).
    #32183
* http:
  * The default maximum HTTP header size was changed from 8KB to 16KB
    (rosaxny). #32520
* n-api:
  * Calls to `napi_call_threadsafe_function` from the main thread can
    now return the `napi_would_deadlock` status in certain
    circumstances (Gabriel Schulhof).
    #32689
* util:
  * Added a new `maxStrLength` option to `util.inspect`, to control the
    maximum length of printed strings. Its default value is `Infinity`
    (rosaxny). #32392
* worker:
  * Added support for passing a `transferList` along with `workerData`
    to the `Worker` constructor (Juan José Arboleda).
    #32278

New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. #32734
* flarna (Gerhard Stoebich). #32620
* mildsunrise (Alba Mendez). #32525

PR-URL: #32813
targos added a commit that referenced this pull request Apr 14, 2020
2020-04-14, Version 13.13.0 (Current)
cf4c332 
Notable changes:

New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
  This function takes an array of `ArrayBufferView` elements and will
  write the data it reads sequentially to the buffers
  (Sk Sajidul Kadir). #32356
* A new overload is available for `fs.readSync`, which allows to
  optionally pass any of the `offset`, `length` and `position`
  parameters. #32460

Other changes:
* dns:
  * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
    `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
    mapped IPv6 addresses (murgatroid99).
    #32183
* http:
  * The default maximum HTTP header size was changed from 8KB to 16KB
    (rosaxny). #32520
* n-api:
  * Calls to `napi_call_threadsafe_function` from the main thread can
    now return the `napi_would_deadlock` status in certain
    circumstances (Gabriel Schulhof).
    #32689
* util:
  * Added a new `maxStrLength` option to `util.inspect`, to control the
    maximum length of printed strings. Its default value is `Infinity`
    (rosaxny). #32392
* worker:
  * Added support for passing a `transferList` along with `workerData`
    to the `Worker` constructor (Juan José Arboleda).
    #32278

New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. #32734
* flarna (Gerhard Stoebich). #32620
* mildsunrise (Alba Mendez). #32525

PR-URL: #32813
targos pushed a commit that referenced this pull request Apr 22, 2020
doc: add himself65 to collaborators
c78019d 
PR-URL: #32734
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Apr 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
gabrielschulhof gabrielschulhof approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL