Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Trott
reviewed
Apr 12, 2020
Comment thread
doc/api/fs.md
Outdated
Copy link
Copy Markdown
Member
|
Welcome, @el5846, and thanks for the pull request! Just want to repeat what I said in the other pull request, which is that documentation pull requests can attract a lot of comments. Please be patient with us! Thanks! |
Sorry, something went wrong.
Trott
reviewed
Apr 12, 2020
Comment thread
doc/api/fs.md
Outdated
addaleax
reviewed
Apr 12, 2020
Comment thread
doc/api/fs.md
Outdated
Fixes: #25595 subdirectory updated def
addaleax
approved these changes
Apr 17, 2020
Copy link
Copy Markdown
Member
|
@el5846 Sorry for the delay here! Landed in ff622a2, and thanks for your pull request! 🎉 |
Sorry, something went wrong.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #25595
[x] make -j4 test (UNIX), or vcbuild test (Windows) passes
[x] documentation is changed or added
[x] commit message follows [commit guidelines]