FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vm: throw error when duplicated exportNames in SyntheticModule by himself65 · Pull Request #32810 · nodejs/node · GitHub

/ node Public

vm: throw error when duplicated exportNames in SyntheticModule - #32810

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200413-vm
ConversationCommits (1)ChecksFiles changed
Closed

vm: throw error when duplicated exportNames in SyntheticModule#32810
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200413-vm

Conversation

himself65 commented Apr 13, 2020

Copy link
Copy Markdown
Member

Fixes: #32806

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label Apr 13, 2020
himself65 requested a review from targos April 13, 2020 10:03
SimenB reviewed Apr 13, 2020
View reviewed changes
Comment thread lib/internal/vm/module.js Outdated

This comment has been minimized.

Sign in to view
targos reviewed Apr 13, 2020
View reviewed changes
Comment thread lib/internal/vm/module.js Outdated
devsnek reviewed Apr 13, 2020
View reviewed changes
Comment thread lib/internal/vm/module.js Outdated
Comment thread lib/internal/vm/module.js Outdated
devsnek reviewed Apr 13, 2020
View reviewed changes
Comment thread test/parallel/test-vm-module-basic.js Outdated

nodejs-github-bot commented Apr 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30685/

himself65 changed the title vm: avoid duplicated exportNames on SyntheticModule vm: throw error when duplicated exportNames in SyntheticModule Apr 13, 2020
SimenB reviewed Apr 13, 2020
View reviewed changes
Comment thread test/parallel/test-vm-module-basic.js Outdated
SimenB reviewed Apr 13, 2020
View reviewed changes
Comment thread lib/internal/vm/module.js Outdated
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 27, 2020

nodejs-github-bot commented Apr 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31040/

himself65 added a commit that referenced this pull request Apr 28, 2020
vm: throw error when duplicated exportNames in SyntheticModule
9545013 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

himself65 commented Apr 28, 2020

Copy link
Copy Markdown
Member Author

landed in 9545013

himself65 closed this Apr 28, 2020
targos pushed a commit that referenced this pull request May 4, 2020
vm: throw error when duplicated exportNames in SyntheticModule
4423304 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
vm: throw error when duplicated exportNames in SyntheticModule
8b4c57f 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
vm: throw error when duplicated exportNames in SyntheticModule
6a9f867 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
+3 more reviewers
SimenB SimenB left review comments
devsnek devsnek left review comments
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SyntheticModule aborts with illegal hardware instruction during linking

6 participants

Back | FazBrowse Home | New Git URL