src: remove validation of unreachable code - #32818
Closed
juanarbol wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Based on nodejs/help#2600 (comment) the condition (amount < 0) won't be possible.
addaleax
approved these changes
Apr 13, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ZYSzys
approved these changes
Apr 13, 2020
himself65
approved these changes
Apr 13, 2020
Copy link
Copy Markdown
Member
Author
|
I think this needs a quick update, it should be unsigned int amount, instead of double amount, if I am right, I can write that little "fix" |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@juanarbol The current code is correct – we want the returned value to be a JS number, which corresponds to double in C++. The assignment to double amount = ... does the conversion implicitly, which is fine for us (although you could add static_cast<double>(...) to make it more explicit). If we did use unsigned int amount, the amount value would be truncated to the size of an unsigned int, which is typically 32 bits; but the value returned from libuv won’t usually fit into that range, so we’d actually get a wrong result in that case. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I think it is ok now, thank you @addaleax !!! |
Sorry, something went wrong.
codebytere
approved these changes
Apr 13, 2020
bnoordhuis
approved these changes
Apr 13, 2020
cjihrig
approved these changes
Apr 13, 2020
jasnell
approved these changes
Apr 15, 2020
devsnek
approved these changes
Apr 15, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
added a commit
that referenced
this pull request
Apr 19, 2020
Based on nodejs/help#2600 (comment) the condition (amount < 0) won't be possible. PR-URL: #32818 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
Based on nodejs/help#2600 (comment) the condition (amount < 0) won't be possible. PR-URL: #32818 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Based on nodejs/help#2600 (comment) the condition (amount < 0) won't be possible. PR-URL: #32818 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
Based on nodejs/help#2600 (comment) the condition (amount < 0) won't be possible. PR-URL: #32818 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on nodejs/help#2600 (comment)
the condition (amount < 0) won't be possible.
Checklist