test: only detect uname on supported os - #32833
Closed
dmabupt wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
To skip some tests on IBMi PASE, we use uname to detect the true os name, but on Windows machines there is no uname available.
dmabupt
marked this pull request as ready for review
April 14, 2020 05:09
jasnell
approved these changes
Apr 15, 2020
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM but let's have @nodejs/crypto and @nodejs/build take a look
Sorry, something went wrong.
tniessen
approved these changes
Apr 15, 2020
sam-github
approved these changes
Apr 15, 2020
ryzokuken
approved these changes
Apr 15, 2020
ryzokuken
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for this, gyp changes LGTM. 💯
Sorry, something went wrong.
addaleax
approved these changes
Apr 15, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Apr 15, 2020
Copy link
Copy Markdown
Contributor
|
CI passes, positive reviews and 2 days have passed. I'm landing this. |
Sorry, something went wrong.
ryzokuken
pushed a commit
that referenced
this pull request
Apr 16, 2020
To skip some tests on IBMi PASE, we use uname to detect the true os name, but on Windows machines there is no uname available. PR-URL: #32833 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2020
To skip some tests on IBMi PASE, we use uname to detect the true os name, but on Windows machines there is no uname available. PR-URL: #32833 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
To skip some tests on IBMi PASE, we use uname to detect the true os name, but on Windows machines there is no uname available. PR-URL: nodejs#32833 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
To skip some tests on IBMi PASE, we use uname to detect the true os name, but on Windows machines there is no uname available. PR-URL: #32833 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
To skip some tests on IBMi PASE, we use uname to detect the true os name, but on Windows machines there is no uname available. PR-URL: #32833 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To skip some tests on IBMi PASE, we use uname to detect the true os name, but
on Windows machines there is no uname available.
This fix the issue in #31967
Tested on Windows, Mac OS and IBM i PASE. May need AIX test as well.