| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
/cc @nodejs/modules-active-members |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for adding this! It feels more consistent.
Sorry, something went wrong.
Sorry, something went wrong.
|
From modules team discussion today it seems fine and "we should just do it" |
Sorry, something went wrong.
PR-URL: #32838 Reviewed-By: Jan Krems <jan.krems@gmail.com>
PR-URL: #32838 Reviewed-By: Jan Krems <jan.krems@gmail.com>
PR-URL: #32838 Reviewed-By: Jan Krems <jan.krems@gmail.com>
PR-URL: #32838 Reviewed-By: Jan Krems <jan.krems@gmail.com>
PR-URL: #32838 Reviewed-By: Jan Krems <jan.krems@gmail.com>
| Back | FazBrowse Home | New Git URL |
This PR includes two changes to exports edge cases:
This comes out of the discussion in hybrist/proposal-pkg-exports#46 where the feature is blacklisting subdirectories via eg:
Both of the above cases would then result in conditional object checks falling through (whereas the current ERR_INVALID_PACKAGE_TARGET for both does not).
There is likely still some discussion to be had here:
Questions:
I tend to think yes, but let's discuss in the meeting further.
Checklist