FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use using NewStringType by rickyes · Pull Request #32843 · nodejs/node · GitHub

/ node Public

src: use using NewStringType - #32843

Closed
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:use-using
ConversationCommits (1)ChecksFiles changed
Closed

src: use using NewStringType#32843
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:use-using

Conversation

rickyes commented Apr 14, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. labels Apr 14, 2020
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 14, 2020

nodejs-github-bot commented Apr 14, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30724/

nodejs-github-bot commented Apr 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30743/

nodejs-github-bot commented Apr 18, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30827/

nodejs-github-bot commented Apr 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30920/

nodejs-github-bot commented Apr 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30922/

nodejs-github-bot commented Apr 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30925/

nodejs-github-bot commented Apr 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30927/

rickyes commented Apr 23, 2020

Copy link
Copy Markdown
Contributor Author

https://ci.nodejs.org/job/node-test-pull-request/30927/

@puzpuzpuz It looks like get a green build.

jasnell pushed a commit that referenced this pull request Apr 23, 2020
src: use using NewStringType
17f1202 
PR-URL: #32843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

jasnell commented Apr 23, 2020

Copy link
Copy Markdown
Member

Landed in 17f1202

jasnell closed this Apr 23, 2020
rickyes deleted the use-using branch April 23, 2020 16:12
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
src: use using NewStringType
95e897e 
PR-URL: #32843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
src: use using NewStringType
015f33c 
PR-URL: #32843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
src: use using NewStringType
be975f9 
PR-URL: #32843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
src: use using NewStringType
05059a2 
PR-URL: #32843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
137717unity mentioned this pull request Mar 22, 2024
Open
baby636 mentioned this pull request Mar 22, 2024
Open
kissofire mentioned this pull request Mar 22, 2024
Open
aliceUnhinged613 mentioned this pull request Mar 22, 2024
Open
ron-a20 mentioned this pull request Mar 22, 2024
Open
wedataintelligence mentioned this pull request Mar 23, 2024
Open
aliceUnhinged613 mentioned this pull request May 13, 2024
Open
molllyn1 mentioned this pull request May 13, 2024
Open
ron-a20 mentioned this pull request May 13, 2024
Open
kissofire mentioned this pull request May 13, 2024
Open
137717unity mentioned this pull request May 14, 2024
Open
baby636 mentioned this pull request May 14, 2024
Open
wedataintelligence mentioned this pull request May 14, 2024
Open
aliceUnhinged613 mentioned this pull request May 15, 2024
Open
kissofire mentioned this pull request May 20, 2024
Open
aliceUnhinged613 mentioned this pull request May 21, 2024
Open
wedataintelligence mentioned this pull request May 21, 2024
Open
137717unity mentioned this pull request May 21, 2024
Open
molllyn1 mentioned this pull request May 21, 2024
Open
ron-a20 mentioned this pull request May 22, 2024
Open
wedataintelligence mentioned this pull request Oct 9, 2024
Open
ron-a20 mentioned this pull request Oct 9, 2024
Open
aliceUnhinged613 mentioned this pull request Oct 11, 2024
Open
137717unity mentioned this pull request Oct 13, 2024
Open
kissofire mentioned this pull request Oct 13, 2024
Open
137717unity mentioned this pull request Oct 20, 2024
Open
kissofire mentioned this pull request Oct 20, 2024
Open
opekeye mentioned this pull request Oct 20, 2024
Open
molllyn1 mentioned this pull request Oct 22, 2024
Open
wedataintelligence mentioned this pull request Oct 22, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
fhinkel fhinkel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL