FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Debug mode tests by bnoordhuis · Pull Request #3293 · nodejs/node · GitHub

/ node Public

Debug mode tests - #3293

Closed
bnoordhuis wants to merge 3 commits into
nodejs:masterfrom
bnoordhuis:debug-mode-tests
ConversationCommits (3)ChecksFiles changed
Closed

Debug mode tests#3293
bnoordhuis wants to merge 3 commits into
nodejs:masterfrom
bnoordhuis:debug-mode-tests

Conversation

bnoordhuis commented Oct 9, 2015

Copy link
Copy Markdown
Member

Refs #3280.

R=@orangemocha

I'll spruce up the commit logs but this is the basic idea of what I mentioned here.

silverwind added the build Issues and PRs related to build files or the CI. label Oct 9, 2015
rvagg reviewed Oct 12, 2015
View reviewed changes
Comment thread tools/test.py Outdated

rvagg Oct 12, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure this comment really adds value here

bnoordhuis Oct 12, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I figured that it wasn't entirely obvious from context what options.mode is and why it needs to be lower-cased. I can remove it if you feel strongly about it.

S-YOU Nov 19, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

'Release' => ['release']?

rvagg commented Oct 12, 2015

Copy link
Copy Markdown
Member

There's a few others in there that could have $(NODE_EXE) replaced with $(NODE), like test-npm and others with test in their name

orangemocha commented Oct 13, 2015

Copy link
Copy Markdown
Contributor

@bnoordhuis good stuff. Changes generally LGTM, though the add-ons tests still need to be fixed.
I have verified that vcbuild.bat doesn't need to be changed.

Prototype job run here: https://ci.nodejs.org/job/orangemocha-test-commit-linux/2/ (still pending)

orangemocha mentioned this pull request Oct 27, 2015
Closed

jasnell commented Mar 22, 2016

Copy link
Copy Markdown
Member

@bnoordhuis ... ping

jasnell added the stalled Issues and PRs that are stalled. label Mar 22, 2016
estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:22
rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:01
bnoordhuis closed this Nov 19, 2016
bnoordhuis deleted the debug-mode-tests branch January 19, 2018 18:13
This was referenced Feb 20, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
snyk-bot mentioned this pull request Sep 25, 2022
Open
wedataintelligence mentioned this pull request Sep 26, 2022
Open
137717unity mentioned this pull request Sep 26, 2022
Open
snyk-bot mentioned this pull request Sep 27, 2022
Open
wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
snyk-bot mentioned this pull request Oct 6, 2022
Open
137717unity mentioned this pull request Oct 7, 2022
Open
wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
137717unity mentioned this pull request Oct 9, 2022
Open
snyk-bot mentioned this pull request Oct 9, 2022
Open
snyk-bot mentioned this pull request Apr 24, 2023
Open
kissofire mentioned this pull request Jun 25, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
S-YOU S-YOU left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. stalled Issues and PRs that are stalled.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL