FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: consistent punctuation by ronag · Pull Request #32934 · nodejs/node · GitHub

/ node Public

stream: consistent punctuation - #32934

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-punctuation
Closed

stream: consistent punctuation#32934
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-punctuation

Conversation

ronag commented Apr 19, 2020

Copy link
Copy Markdown
Member

Cleanup comments to use consistent punctuation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

ronag requested a review from BridgeAR April 19, 2020 21:38
nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Apr 19, 2020
ronag requested a review from benjamingr April 19, 2020 21:38
ronag added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 20, 2020

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Cleanup comments to use consistent punctuation.

ronag commented Apr 23, 2020

Copy link
Copy Markdown
Member Author

rebased to fix conflicts

ronag force-pushed the stream-punctuation branch from f7fde21 to 7134775 Compare April 23, 2020 17:55

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

ronag commented Apr 24, 2020

Copy link
Copy Markdown
Member Author

Landed in 802edb1

ronag closed this Apr 24, 2020
ronag added a commit that referenced this pull request Apr 24, 2020
Cleanup comments to use consistent punctuation.

PR-URL: #32934
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
Cleanup comments to use consistent punctuation.

PR-URL: #32934
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs mentioned this pull request Apr 27, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Cleanup comments to use consistent punctuation.

PR-URL: #32934
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL