FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

path: fix comment grammar by thecodrr · Pull Request #32942 · nodejs/node · GitHub

/ node Public

path: fix comment grammar - #32942

Closed
thecodrr wants to merge 1 commit into
nodejs:masterfrom
thecodrr:grammar
Closed

path: fix comment grammar#32942
thecodrr wants to merge 1 commit into
nodejs:masterfrom
thecodrr:grammar

Conversation

Copy link
Copy Markdown
Contributor

Hi, this is my first PR.

I was looking through the path.js source code and saw some grammar mistakes in one of the comments. Thought it would make a good first PR.

Checklist

nodejs-github-bot added the path Issues and PRs related to the path subsystem. label Apr 20, 2020
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 27, 2020

Copy link
Copy Markdown
Collaborator

addaleax pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>

Copy link
Copy Markdown
Member

Landed in d0377a8 🎉

Thanks for being patient with us!

addaleax closed this Apr 28, 2020
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
targos mentioned this pull request May 4, 2020
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. path Issues and PRs related to the path subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL