FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-child-process-fork-args as flaky on Windows by puzpuzpuz · Pull Request #32950 · nodejs/node · GitHub

/ node Public

test: mark test-child-process-fork-args as flaky on Windows - #32950

Closed
puzpuzpuz wants to merge 1 commit into
nodejs:masterfrom
puzpuzpuz:mark-test-child-process-fork-args-as-flaky
ConversationCommits (1)ChecksFiles changed
Closed

test: mark test-child-process-fork-args as flaky on Windows#32950
puzpuzpuz wants to merge 1 commit into
nodejs:masterfrom
puzpuzpuz:mark-test-child-process-fork-args-as-flaky

Conversation

puzpuzpuz commented Apr 20, 2020

Copy link
Copy Markdown
Member
Checklist

Refs: #32863

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

puzpuzpuz added the test Issues and PRs related to the tests. label Apr 20, 2020
puzpuzpuz mentioned this pull request Apr 20, 2020
Closed
sam-github approved these changes Apr 20, 2020
View reviewed changes

sam-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

sam-github commented Apr 20, 2020

Copy link
Copy Markdown
Contributor

fast-track?

nodejs-github-bot commented Apr 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30877/

nodejs-github-bot commented Apr 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30879/

puzpuzpuz added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 21, 2020
puzpuzpuz added a commit that referenced this pull request Apr 21, 2020
test: mark test-child-process-fork-args as flaky on Windows
7893c70 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

puzpuzpuz commented Apr 21, 2020

Copy link
Copy Markdown
Member Author

Landed in 7893c70

puzpuzpuz closed this Apr 21, 2020
puzpuzpuz deleted the mark-test-child-process-fork-args-as-flaky branch April 21, 2020 09:56
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
test: mark test-child-process-fork-args as flaky on Windows
c9ae385 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
test: mark test-child-process-fork-args as flaky on Windows
944e010 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
test: mark test-child-process-fork-args as flaky on Windows
f7125d2 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
test: mark test-child-process-fork-args as flaky on Windows
0bae243 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
richardlau richardlau approved these changes
juanarbol juanarbol approved these changes
+1 more reviewer
sam-github sam-github approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL