http2: wait for secureConnect before initializing - #32958
Closed
bcoe wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bcoe
requested review from
addaleax and
jasnell
and removed request for
jasnell
April 21, 2020 00:38
This comment has been minimized.
jasnell
approved these changes
Apr 21, 2020
addaleax
approved these changes
Apr 21, 2020
bcoe
commented
Apr 21, 2020
Comment thread
lib/internal/fs/promises.js
Outdated
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Merged
Merged
davedoesdev
reviewed
May 1, 2020
Comment thread
lib/_tls_wrap.js
| this._securePending = false; | ||
| this._newSessionPending = false; | ||
| this._controlReleased = false; | ||
| this.secureConnecting = true; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This is never set to false on client sockets.
So if Http2Session constructor (in lib/internal/http2/core.js) is called after secureConnect is emitted, then secureConnecting is still true but it'll end up never calling setupHandle and connect will never be emitted.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @murgatroid99 points out in #32922, a connection may have its connecting property set to true, while TLS is still connecting. This results in setupFn() being fired before the connection is actually ready.
This PR introduces the property secureConnecting on TLSSocket, which will not be set to true until the secureConnection event is emitted.
Fixes: #32922
Checklist