FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: don't check links in tmp dirs by bnoordhuis · Pull Request #32996 · nodejs/node · GitHub

/ node Public

doc: don't check links in tmp dirs - #32996

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:no-tmpdir-link-check
Closed

doc: don't check links in tmp dirs#32996
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:no-tmpdir-link-check

Conversation

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Apr 22, 2020

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but subsystem should likely be tools: not doc:

Copy link
Copy Markdown
Member Author

That's what I thought too but previous changes all use doc: (and only touch that file, they're not tree-wide changes.)

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 27, 2020

nodejs-github-bot commented Apr 28, 2020
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

Landed in 042c749

addaleax pushed a commit that referenced this pull request Apr 29, 2020
PR-URL: #32996
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax closed this Apr 29, 2020
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #32996
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request May 4, 2020
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #32996
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32996
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL