doc: fix LTS replaceme tags - #33041
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
approved these changes
Apr 24, 2020
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Rubber-stamp. Thank you!
Sorry, something went wrong.
richardlau
approved these changes
Apr 24, 2020
jasnell
approved these changes
Apr 24, 2020
cjihrig
approved these changes
Apr 24, 2020
lpinca
approved these changes
Apr 24, 2020
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
codebytere
approved these changes
Apr 24, 2020
When cherry-picking release commits for LTS releases into master, the `REPLACEME` metadata can be taken over as well, to give users a more accurate view of what is being released on which release line. This addresses this problem for all previous LTS releases for which this has not been done. Fixes: nodejs#33001
addaleax
force-pushed
the
fix-lts-replaceme
branch
from
6e1f542 to
52ec5dc
Compare
April 27, 2020 22:21
addaleax
added a commit
that referenced
this pull request
Apr 28, 2020
When cherry-picking release commits for LTS releases into master, the `REPLACEME` metadata can be taken over as well, to give users a more accurate view of what is being released on which release line. This addresses this problem for all previous LTS releases for which this has not been done. Fixes: #33001 PR-URL: #33041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
When cherry-picking release commits for LTS releases into master, the `REPLACEME` metadata can be taken over as well, to give users a more accurate view of what is being released on which release line. This addresses this problem for all previous LTS releases for which this has not been done. Fixes: #33001 PR-URL: #33041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cherry-picking release commits for LTS releases into master,
the REPLACEME metadata can be taken over as well, to give users
a more accurate view of what is being released on which release line.
This addresses this problem for all previous LTS releases for which
this has not been done.
@nodejs/releasers
Fixes: #33001
Checklist